Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Use shallow git clone in workflows #8166

Merged

Conversation

Damian-Nordic
Copy link
Contributor

@Damian-Nordic Damian-Nordic commented Jul 7, 2021

Problem

Some our github workflows fetch the entire commit history, allegedly to make bloat reports work, but after examining the bloat check script it appears that the requirement may be no longer valid. The bloat check script used to be run as part of the PR workflows, but now there's a separate workflow for the bloat report. Let's try if we can safely switch to the shallow cloning.

Change overview

  • Use shallow cloning for workflows that build the examples.

Testing

CI only change - no testing needed.

@Damian-Nordic Damian-Nordic marked this pull request as draft July 7, 2021 15:25
@Damian-Nordic Damian-Nordic marked this pull request as ready for review July 7, 2021 15:42
@Damian-Nordic Damian-Nordic changed the title [workflows] Use shallow git clone in workflows [DNM] [workflows] Use shallow git clone in workflows Jul 7, 2021
@Damian-Nordic Damian-Nordic marked this pull request as draft July 7, 2021 15:43
Some our github workflows fetch the entire commit history,
allegedly to make bloat reports work, but after examining
the bloat check script it appears that the requirement may
be no longer valid. The bloat check script used to be run
as part of the PR workflows, but now there's a separate
workflow for the bloat report. Let's try if we can safely
switch to the shallow cloning.
@Damian-Nordic Damian-Nordic changed the title [DNM] [workflows] Use shallow git clone in workflows [workflows] Use shallow git clone in workflows Jul 8, 2021
@Damian-Nordic Damian-Nordic marked this pull request as ready for review July 8, 2021 16:04
@Damian-Nordic Damian-Nordic merged commit 742472b into project-chip:master Jul 9, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Some our github workflows fetch the entire commit history,
allegedly to make bloat reports work, but after examining
the bloat check script it appears that the requirement may
be no longer valid. The bloat check script used to be run
as part of the PR workflows, but now there's a separate
workflow for the bloat report. Let's try if we can safely
switch to the shallow cloning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants