Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QPG] Fix CASE session setup flow. Add missing ECDH support through HW crypto engine #8155

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

tima-q
Copy link
Contributor

@tima-q tima-q commented Jul 7, 2021

Problem

ECDH support was enabled in #7948, but was not yet available in our HW engine.
The full CASE session flow could not complete without this functionality.

TODO's

Change overview

  • Remove TODO and #ifdef guard to activated ECDH Derive Secret function.
  • Update QPG SDK and mbedtls config to support ECDH through an HW accelerated ALT version.

Testing

  • Commissioning flow tested with python chip-device-ctrl (ToT and test_event_4 branch)
  • CASE session is established correctly after resolve.

@github-actions
Copy link

github-actions bot commented Jul 7, 2021

Size increase report for "gn_qpg-example-build" from 70f4de0

File Section File VM
chip-qpg6100-lighting-example.out .text -396 -396
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,4841
.debug_loc,0,2454
.debug_line,0,1448
.debug_abbrev,0,1039
.debug_ranges,0,776
[Unmapped],0,396
.debug_frame,0,76
.debug_aranges,0,40
.symtab,0,32
.shstrtab,0,-1
.strtab,0,-7
.debug_str,0,-158
.text,-396,-396

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

github-actions bot commented Jul 7, 2021

Size increase report for "esp32-example-build" from 70f4de0

File Section File VM
chip-lock-app.elf .flash.text -64 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit b5bbee1 into project-chip:master Jul 8, 2021
@tima-q tima-q deleted the qpg/enable_ecdh_derive branch July 8, 2021 18:14
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants