Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TV App] Enable missing attributes #8120

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Jul 5, 2021

Problem

TV example app does not have these attributes enabled:

  • Current Application
  • Current Input
  • Current TV Channel
  • Current TV Lineup

Change overview

  • Updated the tv.zap and enabled attributes
  • Updated the controller.zap and enabled attributes
  • Added tests for new attributes which are now enabled
  • Run ./scripts/tools/zap_regen_all.py to generate code

Testing

  • Used the ./gn_build.sh to verify the building is successful
  • Run the ./scripts/tests/test_suites.sh -a tv

@todo
Copy link

todo bot commented Jul 5, 2021

Enable this once struct as response type is supported

# TODO: Enable this once struct as response type is supported
# response:
# values:
# - name: "status"
# value: 0
# - name: "data"
# value: "data"
# TODO: Read attribute catalog vendor id and Read attribute catalog vendor id
# TODO: shoudl be one test, but currently struct as attribute is not supported
- label: "Read attribute catalog vendor id"


This comment was generated by todo based on a TODO comment in ddd91e3 in #8120. cc @lazarkov.

@todo
Copy link

todo bot commented Jul 5, 2021

Read attribute catalog vendor id and Read attribute catalog vendor id

# TODO: Read attribute catalog vendor id and Read attribute catalog vendor id
# TODO: shoudl be one test, but currently struct as attribute is not supported
- label: "Read attribute catalog vendor id"
command: "readAttribute"
attribute: "catalog vendor id"
response:
value: 0
- label: "Read attribute application id"
command: "readAttribute"
attribute: "application id"


This comment was generated by todo based on a TODO comment in ddd91e3 in #8120. cc @lazarkov.

@todo
Copy link

todo bot commented Jul 5, 2021

shoudl be one test, but currently struct as attribute is not supported

# TODO: shoudl be one test, but currently struct as attribute is not supported
- label: "Read attribute catalog vendor id"
command: "readAttribute"
attribute: "catalog vendor id"
response:
value: 0
- label: "Read attribute application id"
command: "readAttribute"
attribute: "application id"
response:


This comment was generated by todo based on a TODO comment in ddd91e3 in #8120. cc @lazarkov.

@lazarkov lazarkov force-pushed the feature/enable-missing-attributes-for-tv-sdk branch from 50c49c4 to 7ba846a Compare July 6, 2021 15:18
@lazarkov lazarkov force-pushed the feature/enable-missing-attributes-for-tv-sdk branch from 7ba846a to cd39e55 Compare July 6, 2021 18:37
@lazarkov lazarkov force-pushed the feature/enable-missing-attributes-for-tv-sdk branch from cd39e55 to d3aa19d Compare July 6, 2021 21:42
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Size increase report for "esp32-example-build" from 846abd2

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-all-clusters-app.elf .flash.rodata 64 64
chip-all-clusters-app.elf .flash.text -24 -24
chip-shell.elf .flash.text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.xt.prop._ZN4chip6System5Mutex6UnlockEv,0,108
.flash.rodata,64,64
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,48
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,12
.flash.text,-24,-24
.xt.prop._ZN4chip11DeviceLayer8Internal26GenericPlatformManagerImplINS0_19PlatformManagerImplEE14_InitChipStackEv,0,-40
[Unmapped],0,-40
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE10_PostEventEPKNS0_15ChipDeviceEventE,0,-80
.xt.lit._ZN4chip6System5Mutex6UnlockEv,0,-128

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,4
.flash.text,-4,-4


@andy31415 andy31415 merged commit 4fad969 into project-chip:master Jul 7, 2021
andy31415 pushed a commit that referenced this pull request Jul 8, 2021
* Enabling missing attributes as current media input on TV app

* Adding tests for code changes

* Generating the code using ZAP script

* Restyle fix

* Enable attributes on all-clusters app so tests can pass
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* Enabling missing attributes as current media input on TV app

* Adding tests for code changes

* Generating the code using ZAP script

* Restyle fix

* Enable attributes on all-clusters app so tests can pass
@lazarkov lazarkov deleted the feature/enable-missing-attributes-for-tv-sdk branch December 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants