-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TV App] Enable missing attributes #8120
Merged
andy31415
merged 5 commits into
project-chip:master
from
lazarkov:feature/enable-missing-attributes-for-tv-sdk
Jul 7, 2021
Merged
[TV App] Enable missing attributes #8120
andy31415
merged 5 commits into
project-chip:master
from
lazarkov:feature/enable-missing-attributes-for-tv-sdk
Jul 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable this once struct as response type is supported
This comment was generated by todo based on a
|
Read attribute catalog vendor id and Read attribute catalog vendor id
This comment was generated by todo based on a
|
shoudl be one test, but currently struct as attribute is not supported
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
vivien-apple,
wehale and
woody-apple
July 5, 2021 19:20
lazarkov
force-pushed
the
feature/enable-missing-attributes-for-tv-sdk
branch
2 times, most recently
from
July 6, 2021 08:52
a4e69a9
to
50c49c4
Compare
andy31415
approved these changes
Jul 6, 2021
lazarkov
force-pushed
the
feature/enable-missing-attributes-for-tv-sdk
branch
from
July 6, 2021 15:18
50c49c4
to
7ba846a
Compare
jmartinez-silabs
approved these changes
Jul 6, 2021
lazarkov
force-pushed
the
feature/enable-missing-attributes-for-tv-sdk
branch
from
July 6, 2021 18:37
7ba846a
to
cd39e55
Compare
lazarkov
force-pushed
the
feature/enable-missing-attributes-for-tv-sdk
branch
from
July 6, 2021 21:42
cd39e55
to
d3aa19d
Compare
Size increase report for "esp32-example-build" from 846abd2
Full report output
|
jelderton
approved these changes
Jul 7, 2021
This was referenced Jul 7, 2021
andy31415
pushed a commit
that referenced
this pull request
Jul 8, 2021
* Enabling missing attributes as current media input on TV app * Adding tests for code changes * Generating the code using ZAP script * Restyle fix * Enable attributes on all-clusters app so tests can pass
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Enabling missing attributes as current media input on TV app * Adding tests for code changes * Generating the code using ZAP script * Restyle fix * Enable attributes on all-clusters app so tests can pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TV example app does not have these attributes enabled:
Change overview
tv.zap
and enabled attributescontroller.zap
and enabled attributes./scripts/tools/zap_regen_all.py
to generate codeTesting
./gn_build.sh
to verify the building is successful./scripts/tests/test_suites.sh -a tv