pressurement cluster again

[janusheide]

Problem

What is being fixed? Examples:

• Pressure measurement cluster is not moved from existing implementation

Change overview

• Pressure measurement cluster moved into seperate xml

Testing

How was this tested? (at least one bullet point required)

superseeds #7228

[janusheide]

@bzbarsky-apple here is the second attempt, lets see if we can get it merged before the repo runs away again ;)

[bzbarsky-apple]

@janusheide This PR removes the pressure management cluster from various apps (e.g. all-clusters-app). Is that intended?

[bzbarsky-apple]

This should presumably live in some directory where ZAP will find it, which will fix the "this is removing this cluster from everything" problem. Something like src/app/zap-templates/zcl/data-model/chip perhaps?

[bzbarsky-apple]

@janusheide I tried to fix this up, but I don't have write permissions to git@github.com:Grundfos/connectedhomeip.git

The fixup goes like this:

1. git rebase -i to drop the two "add generated stuff" commits.
2. In the "moved xml file to proper folder" commit, drop all changes except the actual renaming of the .xml file.

With that, you are done. You can run regeneration if you want, but there should be no changed to generated files (and ther are not for me), because the XML is just moving around with no other changes.

[janusheide]

I opted to go back to the first commit, which did not contain any auto generated stuff, fix that and force push to the branch, simpler and requires no merging work.

[jmartinez-silabs]

ZAP ci error seems real. The zap configuration file for all-cluster-app (and any that had the pressurment cluster enabled) need to be update also

[janusheide]

I am unable to fix this as the zap tool got broken here after a recent update...

[janusheide]

@jmartinez-silabs too me the zap ci error looks like an error caused by the zap tool, do you have an idea of what needs to be done to fix this?

[jmartinez-silabs]

@janusheide The ZAP error shows that it fails to do the generatoion of files for all-clusters-app base on this .zap configuration.
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
It probably also fails for you localy when you run any generation script. Does any example/controller work?
scripts/tools/zap_regen_all.py

From what I see from the diff files you moved some definitions from one xml file to another. the Pressure Measurement was in another domain and i don't see any change to the configuration files (.zap) Seems like the .zap file is still configured to enable the clusters Pressure Measurement in the Measurement & Sensing domain that doesn't exist anymore.

Verify tha the zap files are correctly configured based on your changes
run ./scripts/tools/zap/configure.sh and open the examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

[andy31415]

/rebase

[bzbarsky-apple]

@jmartinez-silabs @Damian-Nordic @jepenven-silabs @msandstedt @saurabhst Please take a look?

[bzbarsky-apple]

@janusheide Was the change of ScaledTolerance from int16s to int16u purposeful?

[janusheide]

@bzbarsky-apple according to the spec https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/PressureMeasurement.adoc scaled tolerance should be unsigned.

It was unsigned in the zcl raw imported version spec.
https://github.com/CHIP-Specifications/connectedhomeip-spec/commit/5c8e240d94823460e2fbb417ee1811c5597f97cc#diff-1e1868167ee2036591c2cdd83f795b6890f2627f56bbd44169dcd47372d10d79

So it looks like the spec and impl diverted before and now they are the same. To me it makes sense that it is alway positive, but from the definition of the scaled tolerance it looks like a tolerance of +42 and -42 would give the same range, but in different orders.

[bzbarsky-apple]

@janusheide OK, great. I just wanted to make sure that was a purposeful change, since the PR description just talked about moving to a separate XML; not saying we shouldn't have made it in general.