-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CSR Nonce to Android/iOS layer #7987
Conversation
(#7985): Annotate csrNonce as Nullable.connectedhomeip/src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Lines 56 to 65 in b73703d
This comment was generated by todo based on a
|
if (csrNonce != nullptr) | ||
{ | ||
JniByteArray jniCsrNonce(env, csrNonce); | ||
params = params.SetCSRNonce(jniCsrNonce.byteSpan()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this assignment need to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't, I missed this. Will clean this up next time I touch this file...
* Expose csrNonce param to pairDevice() in Android * Expose csrNonce param to pairDevice() in Darwin
Problem
Change overview
csrNonce
parameter inCHIPDeviceController.mm#pairDevice()
andChipDeviceController.java#pairDevice()
.Testing
PairDevice
with an empty 32-byte CSR nonce and verified that commissioning completes successfully.