Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cirque] Use session instead of screen to start flask #7932

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[Cirque] Use session instead of screen to start flask #7932

merged 1 commit into from
Jun 29, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Jun 26, 2021 •
edited
Loading

Problem

  • Sometime flask is not properly stopped after running cirque test.
  • Using ps | grep | kill is not safe

Change overview

Use session instead of screen to start flask

Testing

  • Manually tested with cirque script

@yunhanw-google
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@Damian-Nordic @jepenven-silabs @mspang ?

@woody-apple
Copy link
Contributor

@kghost Note: these are real build failures

@yunhanw-google
Copy link
Contributor

/rebase

@yunhanw-google
Copy link
Contributor

this pr is only updating the cirque script, which should not impact darwin at all, darwin is still failing, maybe rebase?

yunhanw-google
yunhanw-google approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@woody-apple woody-apple merged commit 91a1f67 into project-chip:master Jun 29, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@kghost
[Cirque] Use session instead of screen to start flask (project-chip#7932
0fd0401 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@saurabhst saurabhst saurabhst approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jelderton jelderton jelderton approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kghost @yunhanw-google @woody-apple @msandstedt @saurabhst @jelderton @bzbarsky-apple