Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mbed os port #7926

Merged
merged 16 commits into from
Jun 29, 2021
Merged

Add Mbed os port #7926

merged 16 commits into from
Jun 29, 2021

Conversation

pan-
Copy link
Contributor

@pan- pan- commented Jun 25, 2021

Problem

There is no support for Mbed OS in CHIP.

Summary of Changes

Add Mbed OS support to CHIP.

This is a revival of #6355 now that master is stable again with the Bluetooth provisioning flow.

Few details about the port:

  • Our main development target is the PSOC6 WiFi-BT Prototyping kit from cypress:
  • The port only support WiFi and BLE connectivity; not Thread.
  • There is only one examples in this PR: The lock application. The shell application, lightning app, all cluster app and unit test app are ready and will be submitted when that PR is merged.
  • There is good integration with VSCode, build, flash and debug of the examples supported is provided.

Testing

How was this tested? (at least one bullet point required)

  • If unit tests existed, how were they fixed/modified to prevent this in future?

Chip unit tests are supported by Mbed OS but will be added in a subsequent PR. Reference

  • If integration tests were added, how do they verify this change?

We made integration tests for the lock app running on the mbed platform, it uses chiptool to connect on the board running the application and run pairing. It is not part of this PR but will be submitted in a subsequent PR. Reference

  • If new integration tests are not added, why not?

See above. Too much in one PR.

  • If manually tested, what platforms controller and device platforms were manually tested, and how?

PSOC6 WiFi-BT Prototyping kit + Linux with the chip tool app.

pan- added 4 commits June 25, 2021 19:55
@pan-
Add Mbed OS into chip platforms.
087c8d5 
The platform supports the following features:
- Bluetooth
-  WiFi
- Mdns
- Key/Value store
The integration with network is made with the POSIX socket API
@pan-
Add Mbed os third party repo
35f4de0
@pan-
Add mbed os target config/build files
364e88e
@pan-
Update pigweed environment for Mbed OS
ea47017
@pan-
Copy link
Contributor Author

pan- commented Jun 25, 2021 •
edited
Loading

Two major changes compared to #6355:

  • The Mbed OS POSIX socket adaptation layer has been offloaded to a separate repository which is now imported in third_party.
  • Support of minimal MDNS has been added to the mbed ports.

Other changes just reflect change made to upstream (event queue, select, ... )

@pan- pan- mentioned this pull request Jun 25, 2021
Merged
@pan-
Copy link
Contributor Author

pan- commented Jun 25, 2021 •
edited
Loading

Integration of #7927 is nice to have.

@pan- pan- changed the title Mbed os port Add Mbed os port Jun 25, 2021
@pan- pan- force-pushed the mbed-os-port branch 2 times, most recently from f8820c9 to ebe3417 Compare June 28, 2021 09:54
@woody-apple
Copy link
Contributor

@saurabhst @msandstedt @Damian-Nordic @jepenven-silabs @mspang ?

Damian-Nordic
Damian-Nordic approved these changes Jun 29, 2021
View reviewed changes
src/system/SystemConfig.h Outdated Show resolved Hide resolved
pan- added 12 commits June 29, 2021 14:26
@woody-apple woody-apple merged commit cc13560 into project-chip:master Jun 29, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@pan-
Add Mbed os port (project-chip#7926)
3b4e256 
* Add Mbed OS into chip platforms.
The platform supports the following features:
- Bluetooth
-  WiFi
- Mdns
- Key/Value store
The integration with network is made with the POSIX socket API

* Add Mbed os third party repo

* Add mbed os target config/build files

* Update pigweed environment for Mbed OS

* Integrate Mbed OS into chip build system

* Delay MDNS server start on Mbed OS

* Disable Mdns operations in WatchableEventManagerfor mbed os

* Force InterfaceAddressIterator::GetPrefixLength() to 64 on Mbed OS.

* Add Mbed OS shell streamer

* Add Mbed OS SystemMutex implementation

* Add script to build Mbed OS example

* Update devcontainer to flash and debug mbed boards

* Add workflow to build Mbed OS examples

* Add VSCode task to build Mbed OS examples

* Add Mbed OS lock app example.
Note: Bluetooth autostart as there is not enough physical button on
the board. This will be addressed by a subsequent update that enable
capacitive button.

* Add vscode debug configuration for mbed os examples
@ATmobica ATmobica deleted the mbed-os-port branch May 11, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@woody-apple woody-apple woody-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
config examples github review - approved vscode workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pan- @woody-apple @msandstedt @bzbarsky-apple @Damian-Nordic