Fix some logging formats

[bzbarsky-apple]

Problem

Compile error on some compiler; reported on Slack

Change overview

Use the right format.

Testing

Compiled locally, but the real test will be whether the bug reporter can compile...

[bluebin14]

For reference the format errors (hundreds of them in generated code) were caused by two lines in zap template, e.g.

../../../../../src/controller/data_model/gen/IMClusterCommandHandler.cpp:127:83: error: format specifies type 'unsigned short' but the argument has type 'chip::CommandId' (aka 'unsigned char') [-Werror,-Wformat]
ChipLogError(Zcl, "Unknown command %" PRIx16 " for cluster %" PRIx16, aCommandId, ZCL_ACCOUNT_LOGIN_CLUSTER_ID);

../../../../../examples/chip-tool/commands/clusters/Commands.h:1213:99: error: format specifies type 'unsigned short' but the argument has type 'uint8_t' (aka 'unsigned char') [-Werror,-Wformat]
ChipLogProgress(chipTool, "Sending cluster (0x050E) command (0x00) on endpoint %" PRIu16, endpointId);

Confirming that the PR fixes the errors.

[bluebin14]

You can reproduce the build failure with any version of llvm/clang, e.g. edit examples/chip-tool/BUILD.gn so it has the following cflags:

cflags = [
"-Wconversion",
"-Wformat-type-confusion",
]

Build will fail due to type confusion with the same errors as above. Adding -Wformat-type-confusion to global settings would catch future errors.

[bzbarsky-apple]

Adding -Wformat-type-confusion to global settings would catch future errors.

Filed #7935 on this; need to find the right place to add this.