Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some clusters from data-model/silabs and add data-model/chip #7915

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

This is a split of #7873 that contains the removals of various clusters as well as new types from the spec. But the current types are not changed. I will focus on the types change in #7873

Change overview

  • Add src/app/zap-templates/zcl/data-model/chip and move the zap definitions from src/app/zap-templates/zcl there
  • Remove some definitions from src/app/zap-templates/zcl/data-model/Silabs
  • Move types definition from src/app/zap-templates/zcl/data-model/Silabs/types.xml to src/app/zap-templates/zcl/data-model/chip/chip-types.xml and add some extra types from the spec
  • Update gen/ code

Testing

This was tested manually by running ./scripts/tests/test_suite.sh. This is mostly code removal so I won't expect any side effects if it builds.

@vivien-apple
Copy link
Contributor Author

The changes in src/app/util/basic-types.h are only re-ordering alphabetically the types and the addition of new types. I have done it in this PR in order to make it easier to spot which types will be updated in #7873

@bzbarsky-apple
Copy link
Contributor

@msandstedt @andy31415 @mspang @Damian-Nordic @jmartinez-silabs Could you please take a look?

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 336533f

File Section File VM
chip-lock.elf rodata 24 24
chip-lock.elf text 12 12
chip-lock.elf device_handles -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,28
.debug_line,0,4

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_loc,0,80
.debug_line,0,48
.debug_ranges,0,48
rodata,24,24
text,12,12
device_handles,-12,-12
.debug_str,0,-604
.debug_info,0,-5572


@github-actions
Copy link

Size increase report for "esp32-example-build" from 336533f

File Section File VM
chip-all-clusters-app.elf .flash.text 36 36
chip-all-clusters-app.elf .flash.rodata 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,91
.debug_loc,0,60
.flash.text,36,36
.flash.rodata,16,16
[Unmapped],0,-16
.debug_abbrev,0,-22
.debug_str,0,-603
.debug_info,0,-13490

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@woody-apple
Copy link
Contributor

@saurabhst ?

nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…roject-chip#7915)

* Remove some clusters from data-model/silabs and add data-model/chip

foo

* Update gen/ folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants