-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some clusters from data-model/silabs and add data-model/chip #7915
Remove some clusters from data-model/silabs and add data-model/chip #7915
Conversation
The changes in |
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml
Show resolved
Hide resolved
@msandstedt @andy31415 @mspang @Damian-Nordic @jmartinez-silabs Could you please take a look? |
Size increase report for "nrfconnect-example-build" from 336533f
Full report output
|
Size increase report for "esp32-example-build" from 336533f
Full report output
|
8798c8c
to
ab96ff0
Compare
…roject-chip#7915) * Remove some clusters from data-model/silabs and add data-model/chip foo * Update gen/ folders
Problem
This is a split of #7873 that contains the removals of various clusters as well as new types from the spec. But the current types are not changed. I will focus on the types change in #7873
Change overview
src/app/zap-templates/zcl/data-model/chip
and move the zap definitions fromsrc/app/zap-templates/zcl
theresrc/app/zap-templates/zcl/data-model/Silabs
src/app/zap-templates/zcl/data-model/Silabs/types.xml
tosrc/app/zap-templates/zcl/data-model/chip/chip-types.xml
and add some extra types from the specTesting
This was tested manually by running
./scripts/tests/test_suite.sh
. This is mostly code removal so I won't expect any side effects if it builds.