Use CASE for our "Tests" test suite. #7896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
mspang
approved these changes
Jun 25, 2021
msandstedt
approved these changes
Jun 25, 2021
saurabhst
approved these changes
Jun 25, 2021
bzbarsky-apple
force-pushed
the
use-case-tests
branch
from
2753abe
to
68b1e2a
Compare
woody-apple
approved these changes
Jun 25, 2021
bzbarsky-apple
force-pushed
the
use-case-tests
branch
from
68b1e2a
to
3117b0c
Compare
There are four changes here: 1) When doing onnetwork commissioning, make sure to run the part of the commissioning state machine that is meant to run on the operational network, starting with the mdns resolution of the device operational address. This ensures that we put ourselves into a state where we know the operational cert is fully provisioned on the device and we can talk to it via CASE. 2) Fix the fabric id in the script's pairing command to match the fabric id all-clusters-app advertises, so our operational discovery looks for the right thing. 3) Ensure that we actually start operational advertisement when we get a new opcert. Just restarting our mdns server does not do that, due to project-chip#7911 4) Don't fail out on UpdateAddress attempts when there is no connection; that's not an error condition and should not be communicated as such to consumers.
bzbarsky-apple
force-pushed
the
use-case-tests
branch
from
3117b0c
to
91bd3f0
Compare
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
There are four changes here: 1) When doing onnetwork commissioning, make sure to run the part of the commissioning state machine that is meant to run on the operational network, starting with the mdns resolution of the device operational address. This ensures that we put ourselves into a state where we know the operational cert is fully provisioned on the device and we can talk to it via CASE. 2) Fix the fabric id in the script's pairing command to match the fabric id all-clusters-app advertises, so our operational discovery looks for the right thing. 3) Ensure that we actually start operational advertisement when we get a new opcert. Just restarting our mdns server does not do that, due to project-chip#7911 4) Don't fail out on UpdateAddress attempts when there is no connection; that's not an error condition and should not be communicated as such to consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here:
When doing onnetwork commissioning, make sure to run the part of
the commissioning state machine that is meant to run on the
operational network, starting with the mdns resolution of the device
operational address. This ensures that we put ourselves into a state
where we know the operational cert is fully provisioned on the device
and we can talk to it via CASE.
Fix the fabric id in the script's pairing command to match the
fabric id all-clusters-app advertises, so our operational discovery
looks for the right thing.
Problem
The "Tests" test suite was never really "finishing" commissioning and continuing to talk to all-clusters-app via the PASE session.
Change overview
See above.
Testing
Manually verified that CASE session establishment now shows up in the log and that the tests still pass. We don't have a real way to tell whether a given key id corresponds to a CASE or PASE session, so I am taking it somewhat on faith that we are actually using the CASE connection we set up.