Integrated Zephyr shell with the CHIP lib shell #7848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
config
documentation
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
kkasperczyk-no
force-pushed
the
zephyr_shell_integration_pr
branch
from
35c3b12
to
f176594
Compare
|
Looks like you need to exclude |
woody-apple
approved these changes
Jun 23, 2021
Currently there was a standalone CHIP shell example using CHIP lib shell and there was a Zephyr shell used only by nrfconnect platform with some specific commands. The goal is to use for Zephyr based platforms the CHIP lib shell but with Zephyr shell backend integrated and be able to use it in every example, not only standalone shell app. For nrfconnect: * Removed custom Zephyr-based ChipShell.cpp and CONFIG_CHIP_ZEPHYR_SHELL option. * Renamed CONFIG_CHIP_STANDALONE_SHELL to the CONFIG_CHIP_LIB_SHELL. * Aligned console docs to the new commands. For all: * Extended existing shell commands by ble adv <state>, onboardingcodes <qrcode|qrcodeurl|manualpairingcode>, nfc <start|stop|state> and device factoryreset. * Added MainLoopZephyr.cpp file for Zephyr-based platforms, that enables Zephyr shell and is kind of integration layer between CHIP shell and Zephyr shell. * Removed from streamer_zephyr.cpp part not using Zephyr shell.
kkasperczyk-no
force-pushed
the
zephyr_shell_integration_pr
branch
from
f176594
to
8ddb223
Compare
|
@Damian-Nordic I hope now it should be fine. I removed building lib/shell by default even if it is not enabled and also protected building app/server with platform == none. |
Damian-Nordic
approved these changes
Jun 24, 2021
mspang
approved these changes
Jun 24, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Currently there was a standalone CHIP shell example using CHIP lib shell and there was a Zephyr shell used only by nrfconnect platform with some specific commands. The goal is to use for Zephyr based platforms the CHIP lib shell but with Zephyr shell backend integrated and be able to use it in every example, not only standalone shell app. For nrfconnect: * Removed custom Zephyr-based ChipShell.cpp and CONFIG_CHIP_ZEPHYR_SHELL option. * Renamed CONFIG_CHIP_STANDALONE_SHELL to the CONFIG_CHIP_LIB_SHELL. * Aligned console docs to the new commands. For all: * Extended existing shell commands by ble adv <state>, onboardingcodes <qrcode|qrcodeurl|manualpairingcode>, nfc <start|stop|state> and device factoryreset. * Added MainLoopZephyr.cpp file for Zephyr-based platforms, that enables Zephyr shell and is kind of integration layer between CHIP shell and Zephyr shell. * Removed from streamer_zephyr.cpp part not using Zephyr shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there was a standalone CHIP shell example using CHIP lib shell and there was a Zephyr shell used only by
nrfconnect platform with some specific commands. The goal is to use for Zephyr based platforms the CHIP lib shell
but with Zephyr shell backend integrated and be able to use it in every example, not only standalone shell app.
Change overview
For nrfconnect:
For all:
nfc <start|stop|state> and device factoryreset.
between CHIP shell and Zephyr shell.
Testing
Tested manually that commands are handled properly and returns expected values. Test were done only on nrfconnect platform as change affects only that one.