Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/secure element ci #7816
Feature/secure element ci #7816
Changes from 34 commits
6cb0be4
d9bc02d
cb188fd
3eeae9d
f6c0643
a5b1d58
057cea2
7540d7c
3dd6106
6dd9ee8
2279514
826193f
d894136
51bfaa9
4a5f52b
96fe91f
ea76cfe
c19abf6
bf1d5cf
fcbf352
8947ae9
9ca274b
140a0cb
c72a761
5bd7db4
ff18c1f
2e6d0cf
5c61344
5d00d7b
bfd59b6
945ddc4
d7bea68
627eb1b
d3e9662
20281a7
914e49b
ca69fb2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in particular, why can't
error
stay const here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The change was not required..It is the same now(no changes now after the latest commit). This had got changed for VerifyOrExit which was being used sometime earlier and "error variable" was being reused. now VerifyOrReturnError is being used and the change is not required.