Clean up lwIP build file #7790
Merged
Clean up lwIP build file #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use lwipopts.h exclusively for #defines - Match the defaults to those from lwip/opt.h - Remove examples as they are not needed
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
yufengwangca
tcarmelveilleux
approved these changes
Jun 21, 2021
msandstedt
approved these changes
Jun 21, 2021
yufengwangca
approved these changes
Jun 21, 2021
andy31415
approved these changes
Jun 21, 2021
jmartinez-silabs
approved these changes
Jun 21, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
- Use lwipopts.h exclusively for #defines - Match the defaults to those from lwip/opt.h - Remove examples as they are not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The lwIP build file is specifying some configuration options on the
compiler command line. This seemed like a decent way to validate the list
of source files compiled matched the preprocessor configuration, however
this isn't actually necessary - turning off most options like IPV4 just
empties out all of the IPV4 specific files.
Change overview
Testing
gn gen --root-target=//examples/lighting-app/efr32 --args='import("//examples/lighting-app/efr32/args.gni") target_os="freertos" target_cpu="arm" efr32_board="BRD4161A"' out/efr32_lighting_app && gn desc out/efr32_lighting_app //src/lib defines