Move src/app configuration to generated header #7789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We generate headers containing build time configuration choices for good
reason: some builds use multiple build systems and writing out a header
is how we ensure consistent choices are made between them (thus avoiding
ODR violations that can cause catastrophic breakage).
Change overview
Move the command line #defines for src/app to a new generated header.
This makes it safe to enable schema checking in hybrid builds if this is
desired.
Testing
gn gen out/host && gn desc out/host //src/lib defines
ninja -C out/host src/app && cat out/host/gen/include/app/AppBuildConfig.h