Move src/app configuration to generated header #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generate headers containing build time configuration choices for good reason: some builds use multiple build systems and writing out a header is how we ensure consistent choices are made between them (thus avoiding ODR violations that can cause catastrophic breakage). Move the command line #defines for src/app to a new generated header. This makes it safe to enable schema checking in hybrid builds if this is desired.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst and
woody-apple
andy31415
approved these changes
Jun 21, 2021
saurabhst
approved these changes
Jun 21, 2021
Damian-Nordic
approved these changes
Jun 21, 2021
jmartinez-silabs
approved these changes
Jun 21, 2021
jelderton
approved these changes
Jun 21, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
We generate headers containing build time configuration choices for good reason: some builds use multiple build systems and writing out a header is how we ensure consistent choices are made between them (thus avoiding ODR violations that can cause catastrophic breakage). Move the command line #defines for src/app to a new generated header. This makes it safe to enable schema checking in hybrid builds if this is desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We generate headers containing build time configuration choices for good
reason: some builds use multiple build systems and writing out a header
is how we ensure consistent choices are made between them (thus avoiding
ODR violations that can cause catastrophic breakage).
Change overview
Move the command line #defines for src/app to a new generated header.
This makes it safe to enable schema checking in hybrid builds if this is
desired.
Testing
gn gen out/host && gn desc out/host //src/lib definesninja -C out/host src/app && cat out/host/gen/include/app/AppBuildConfig.h