CHIP QRCode command line tool implementation #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
woody-apple
approved these changes
May 19, 2020
gerickson
reviewed
May 19, 2020
gerickson
reviewed
May 19, 2020
gerickson
reviewed
May 19, 2020
gerickson
reviewed
May 19, 2020
gerickson
reviewed
May 19, 2020
bhaskar-apple
force-pushed
the
sazria/cltool
branch
2 times, most recently
from
def49ee
to
ae87515
Compare
bhaskar-apple
force-pushed
the
sazria/cltool
branch
from
ae87515
to
1a38fce
Compare
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
- Coverage 59.16% 56.01% -3.15%
==========================================
Files 130 133 +3
Lines 12652 12836 +184
==========================================
- Hits 7485 7190 -295
- Misses 5167 5646 +479
Continue to review full report at Codecov.
|
saurabhst
approved these changes
May 20, 2020
jelderton
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vendors need a command line tool to help generate qr codes from setup payload
Create a C++ QRCode command line tool
Summary of Changes
Create a command line tool that can generate a qr code or manual code from a text file.
fixes #165