K32W: Fix header paths breaking --check builds #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
force-pushed
the
for-chip/fix-k32-includes
branch
from
af46afe
to
8cbcdc8
Compare
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst and
woody-apple
saurabhst
approved these changes
Jun 14, 2021
jmartinez-silabs
approved these changes
Jun 14, 2021
andy31415
approved these changes
Jun 14, 2021
mspang
force-pushed
the
for-chip/fix-k32-includes
branch
from
8cbcdc8
to
14718be
Compare
|
@mspang Looks like a real build failure |
mspang
force-pushed
the
for-chip/fix-k32-includes
branch
from
502f767
to
7d6027c
Compare
Some header paths are specified incorrectly. This is only an error
when generating the build with the --check option:
ERROR at //third_party/k32w_sdk/k32w_sdk.gni:218:3: Source file not found.
source_set(sdk_target_name) {
^----------------------------
The target:
//examples/lock-app/k32w:sdk
has a source file:
//examples/platform/k32w/OpenThreadConfig.h
which was not found.
Fix the paths and enable --check.
Tested by:
(cd ./examples/lock-app/k32w; gn gen --check out/debug --args='k32w_sdk_root="/home/spang/sdk/k32w_sdk"'; ninja -C out/debug)
mspang
force-pushed
the
for-chip/fix-k32-includes
branch
from
7d6027c
to
e644508
Compare
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Some header paths are specified incorrectly. This is only an error
when generating the build with the --check option:
ERROR at //third_party/k32w_sdk/k32w_sdk.gni:218:3: Source file not found.
source_set(sdk_target_name) {
^----------------------------
The target:
//examples/lock-app/k32w:sdk
has a source file:
//examples/platform/k32w/OpenThreadConfig.h
which was not found.
Fix the paths and enable --check.
Tested by:
(cd ./examples/lock-app/k32w; gn gen --check out/debug --args='k32w_sdk_root="/home/spang/sdk/k32w_sdk"'; ninja -C out/debug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some header paths are specified incorrectly. This is only an error
when generating the build with the --check option:
Change overview
Fix the paths and enable --check.
Testing
Tested by:
(cd ./examples/lock-app/k32w; gn gen --check out/debug --args='k32w_sdk_root="/home/spang/sdk/k32w_sdk"'; ninja -C out/debug)