-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up defines in src/platform/BUILD.gn #7575
Merged
andy31415
merged 1 commit into
project-chip:master
from
mspang:for-chip/cleanup-platform-defines
Jun 14, 2021
Merged
Clean up defines in src/platform/BUILD.gn #7575
andy31415
merged 1 commit into
project-chip:master
from
mspang:for-chip/cleanup-platform-defines
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be fatal for development. Change once bugs are fixedconnectedhomeip/src/platform/BUILD.gn Lines 65 to 75 in bcadfbf
This comment was generated by todo based on a
|
may want to enable at least logging for embedded to find bugsconnectedhomeip/src/platform/BUILD.gn Lines 68 to 78 in bcadfbf
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst,
vivien-apple and
woody-apple
June 13, 2021 21:13
mspang
force-pushed
the
for-chip/cleanup-platform-defines
branch
from
June 13, 2021 23:06
bcadfbf
to
a7cf216
Compare
mspang
force-pushed
the
for-chip/cleanup-platform-defines
branch
from
June 13, 2021 23:08
a7cf216
to
229c191
Compare
- Separate true/false defines are no longer required, as the header generator maps "true" to 1 and "false" to 0. - We should be setting false config #defines to 0 so that we can build with -Wundef Move defines into the main list where possible so that they are always added to the generated header.
mspang
force-pushed
the
for-chip/cleanup-platform-defines
branch
from
June 14, 2021 02:24
229c191
to
bdc5fd8
Compare
woody-apple
approved these changes
Jun 14, 2021
jmartinez-silabs
approved these changes
Jun 14, 2021
andy31415
approved these changes
Jun 14, 2021
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 15, 2021
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 15, 2021
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jun 15, 2021
woody-apple
pushed a commit
that referenced
this pull request
Jun 15, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
- Separate true/false defines are no longer required, as the header generator maps "true" to 1 and "false" to 0. - We should be setting false config #defines to 0 so that we can build with -Wundef Move defines into the main list where possible so that they are always added to the generated header.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate true/false defines are no longer required, as the header
generator maps "true" to 1 and "false" to 0.
We should be setting false config #defines to 0 so that we
can build with -Wundef
Move defines into the main list where possible so that they are always
added to the generated header.
Tested by: