When the "Test Suites" job fails on Darwin, upload core and object files as artifacts. #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda and
saurabhst
woody-apple
approved these changes
Jun 10, 2021
…les as artifacts. If the failure was due to a crash, this allows us to debug the crash. Unfortunately, I don't see an obvious way to only do the upload if the failure was due a crash. Luckily the big thing is the core file and that won't exist if this is not a crash failure.
bzbarsky-apple
force-pushed
the
upload-darwin-cores
branch
from
61a901d
to
a11beab
Compare
|
@mspang @andy31415 @msandstedt @Damian-Nordic @jmartinez-silabs @saurabhst please take a look? |
saurabhst
approved these changes
Jun 15, 2021
jmartinez-silabs
approved these changes
Jun 15, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…les as artifacts. (project-chip#7531) If the failure was due to a crash, this allows us to debug the crash. Unfortunately, I don't see an obvious way to only do the upload if the failure was due a crash. Luckily the big thing is the core file and that won't exist if this is not a crash failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the failure was due to a crash, this allows us to debug the crash.
Unfortunately, I don't see an obvious way to only do the upload if the
failure was due a crash. Luckily the big thing is the core file and
that won't exist if this is not a crash failure.
Problem
We keep seeing crashes in CI and now knowing what happened.
Change overview
Upload binaries and core files to allow debugging.
Testing
Did pushes to my own fork with
VerifyOrDie(false)inserted in the tests to ensure that the artifacts are properly uploaded.