When the "Test Suites" job fails on Darwin, upload core and object files as artifacts. #7531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the failure was due to a crash, this allows us to debug the crash.
Unfortunately, I don't see an obvious way to only do the upload if the
failure was due a crash. Luckily the big thing is the core file and
that won't exist if this is not a crash failure.
Problem
We keep seeing crashes in CI and now knowing what happened.
Change overview
Upload binaries and core files to allow debugging.
Testing
Did pushes to my own fork with
VerifyOrDie(false)
inserted in the tests to ensure that the artifacts are properly uploaded.