Remove linux clang_experimental build #7467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
force-pushed
the
for-chip/remove-experimental-build
branch
from
ba7b4a7 to
358114d
Compare
As of 80120a20 ("[im] Always use interaction model to send commands
(project-chip#5945)"), this build is equivalent to the clang build. Add
--fail-on-unused-args to gn_gen.sh to avoid this happening again.
mspang
force-pushed
the
for-chip/remove-experimental-build
branch
from
358114d to
d965512
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
yunhanw-google
approved these changes
Jun 8, 2021
saurabhst
approved these changes
Jun 8, 2021
msandstedt
approved these changes
Jun 9, 2021
Damian-Nordic
approved these changes
Jun 9, 2021
bzbarsky-apple
approved these changes
Jun 9, 2021
andy31415
approved these changes
Jun 9, 2021
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 15, 2021
This build was intended to be removed in 9488c1a ("Remove linux clang_experimental build (project-chip#7467)") but was left in the matrix and has since been wasting capacity. To prevent waste going forward, make unrecognized build types in the matrix fail when deriving the arguments. Also, simplify the arguments setting a bit - for brevity options that are defaults are not specified; the original builds worked this way but the new logging build did not.
mspang
added a commit
that referenced
this pull request
Jul 19, 2021
This build was intended to be removed in 9488c1a ("Remove linux clang_experimental build (#7467)") but was left in the matrix and has since been wasting capacity. To prevent waste going forward, make unrecognized build types in the matrix fail when deriving the arguments. Also, simplify the arguments setting a bit - for brevity options that are defaults are not specified; the original builds worked this way but the new logging build did not.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
As of 80120a20 ("[im] Always use interaction model to send commands
(project-chip#5945)"), this build is equivalent to the clang build. Add
--fail-on-unused-args to gn_gen.sh to avoid this happening again.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
This build was intended to be removed in 9488c1a ("Remove linux clang_experimental build (project-chip#7467)") but was left in the matrix and has since been wasting capacity. To prevent waste going forward, make unrecognized build types in the matrix fail when deriving the arguments. Also, simplify the arguments setting a bit - for brevity options that are defaults are not specified; the original builds worked this way but the new logging build did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 80120a20 ("[im] Always use interaction model to send commands
(#5945)"), this build is equivalent to the clang build. Add
--fail-on-unused-args to gn_gen.sh to avoid this happening again.