[esp32] reduce default event queue size #7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
dhrishi
reviewed
May 28, 2021
dhrishi
approved these changes
May 28, 2021
jmartinez-silabs
approved these changes
May 28, 2021
|
Why is the event queue too large? It is too large for QPG where it was reduced to save RAM, however if the larger devices support it, is there any reason to reduce it? Please add more details about why this change is required in the summary. |
gjc13
changed the title
|
@andy31415 @tcarmelveilleux The defautl value in the platform config is left default and the value in ESP32 Kconfig is modified since we do have received complaints on heap usage. |
|
/rebase |
LuDuda
approved these changes
Jun 3, 2021
|
/rebase |
The event queue is way too large by default, occupying 6.4 KB. This PR reduces its size to optimize heap usage on esp32.
woody-apple
force-pushed
the
reduce-event-queue
branch
from
a8034c2 to
7339925
Compare
mspang
approved these changes
Jun 7, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
The event queue is way too large by default, occupying 6.4 KB. This PR reduces its size to optimize heap usage on esp32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The event queue is way too large by default, occupying 6.4 KB.
Change overview
Reduce the default event queue size to 25. This value has teen long used in qpg and efr platforms.
Testing
Build all-cluster-app on ESP32 and pair with chip-device-ctrl. The pairing flow can still work.