Example operational credentials issuer for tests and tools #6598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
sagar-apple
msandstedt
approved these changes
May 7, 2021
woody-apple
approved these changes
May 7, 2021
andy31415
approved these changes
May 10, 2021
|
This seems to break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need a sample operational certificate issuer for test apps and tools. Without it, once OpCreds is integrated to commissioning flow, the commissioner apps such as chip-tool, Python tool and other apps will stop working.
Summary of Changes
Implemented an example certificate issuer and integrated to tools in CHIP project.
Also, added a check in
DeviceCommissionerwhich makes it mandatory to have an operational certificate issuer.