Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nlbuild-autotools to 1.6.18, Addressing Shellcheck Issues #65

Conversation

gerickson
Copy link
Contributor

@gerickson gerickson commented Mar 17, 2020

This pull request updates nlbuild-autotools to 1.6.18, which addresses several shellcheck warnings and a potential srcdir and abs_srcdir inconsistency issue in 'bootstrap'.

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks great :)

@gerickson gerickson changed the title Update nlbuild-autotools to 1.6.17, Addressing Shellcheck Issues Update nlbuild-autotools to 1.6.18, Addressing Shellcheck Issues Mar 18, 2020
@woody-apple
Copy link
Contributor

@hawk248 ?

Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit 8c7adec into project-chip:master Mar 18, 2020
@gerickson gerickson deleted the user/gerickson/update-nlbuild-autotools-1.6.17 branch March 18, 2020 17:29
jmartinez-silabs referenced this pull request in SiliconLabs/matter Sep 8, 2022
Merge in WMN_TOOLS/matter from rc3_cherrypicks to RC_0.3.0

Squashed commit of the following:

commit bbfbb9c82faae045a2f47453f9e589065ea50edd
Author: Junior Martinez <junior.martinez@silabs.com>
Date:   Fri Sep 2 13:24:15 2022 -0400

    re-enable BRD4162A for wifi builds as it is support with the workswith branch of matter_support

commit 1509b4aa5f9ebaf6c6f727a893160dd086893912
Author: Junior Martinez <junior.martinez@silabs.com>
Date:   Fri Sep 2 13:22:21 2022 -0400

    Change matter_support submodule to point to the workswith branch

commit 46c630d083cf305e1f33351180449ea500ac8690
Author: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com>
Date:   Wed Aug 31 00:24:32 2022 -0400

    Add openthread lib with coap api enabled (project-chip#22276)

commit 0e3839fdc48e7373000705f8bea1a993dd27b5a4
Author: Jean-Francois Penven <67962328+jepenven-silabs@users.noreply.github.com>
Date:   Thu Sep 1 17:42:34 2022 -0400

    Fix wf200 openthread include (project-chip#22347)

commit 439b376dba33d43ca213434f5d0473ebe2c1d3bb
Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Date:   Thu Sep 1 16:26:49 2022 -0400

    Fix thermostat build (project-chip#22346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants