Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tv-app gen folder for tests bustage #6483

Merged
merged 1 commit into from
May 5, 2021

Conversation

vivien-apple
Copy link
Contributor

Problem

Seems like a bad merge has broken the gen/ folder of the TV-app.

Summary of Changes

  • Update it

@vivien-apple vivien-apple self-assigned this May 5, 2021
@todo
Copy link

todo bot commented May 5, 2021

(#5542): The cluster handlers should accept a ByteSpan for all string types.

// TODO(#5542): The cluster handlers should accept a ByteSpan for all string types.
TLVUnpackError = aDataTlv.GetDataPtr(data);
if (CHIP_NO_ERROR == TLVUnpackError)
{
dataExists = true;
validArgumentCount++;
}
break;
case 1:
if (applicationExists)
{


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5590) We should encode a response of status code for invalid TLV.

// TODO(#5590) We should encode a response of status code for invalid TLV.
if (CHIP_NO_ERROR == TLVError && CHIP_NO_ERROR == TLVUnpackError && 2 == validArgumentCount)
{
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfApplicationLauncherClusterLaunchAppCallback(apCommandObj, const_cast<uint8_t *>(data), application);
}
else
{
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kBadRequest,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogProgress(


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfApplicationLauncherClusterLaunchAppCallback(apCommandObj, const_cast<uint8_t *>(data), application);
}
else
{
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kBadRequest,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogProgress(
Zcl, "Failed to dispatch command, %d/%" PRIu32 " arguments parsed, TLVError=%" PRIu32 ", UnpackError=%" PRIu32,
2, validArgumentCount, TLVError, TLVUnpackError);
}


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfLowPowerClusterSleepCallback(apCommandObj);
break;
}
default: {
// Unrecognized command ID, error status will apply.
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kNotFound,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogError(Zcl, "Unknown command %" PRIx16 " for cluster %" PRIx16, aCommandId, ZCL_LOW_POWER_CLUSTER_ID);
break;
}


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaInputClusterHideInputStatusCallback(apCommandObj);
break;
}
case ZCL_RENAME_INPUT_COMMAND_ID: {
// We are using TLVUnpackError and TLVError here since both of them can be CHIP_END_OF_TLV
// When TLVError is CHIP_END_OF_TLV, it means we have iterated all of the items, which is not a real error.
// Any error value TLVUnpackError means we have received an illegal value.
CHIP_ERROR TLVError = CHIP_NO_ERROR;
CHIP_ERROR TLVUnpackError = CHIP_NO_ERROR;
uint8_t index;


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5542): The cluster handlers should accept a ByteSpan for all string types.

// TODO(#5542): The cluster handlers should accept a ByteSpan for all string types.
TLVUnpackError = aDataTlv.GetDataPtr(name);
if (CHIP_NO_ERROR == TLVUnpackError)
{
nameExists = true;
validArgumentCount++;
}
break;


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaInputClusterShowInputStatusCallback(apCommandObj);
break;
}
default: {
// Unrecognized command ID, error status will apply.
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kNotFound,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogError(Zcl, "Unknown command %" PRIx16 " for cluster %" PRIx16, aCommandId, ZCL_MEDIA_INPUT_CLUSTER_ID);
break;
}


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaFastForwardCallback(apCommandObj);
break;
}
case ZCL_MEDIA_NEXT_COMMAND_ID: {
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaNextCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PAUSE_COMMAND_ID: {


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaNextCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PAUSE_COMMAND_ID: {
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPauseCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PLAY_COMMAND_ID: {


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label May 5, 2021
@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPauseCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PLAY_COMMAND_ID: {
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPlayCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PREVIOUS_COMMAND_ID: {


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPlayCallback(apCommandObj);
break;
}
case ZCL_MEDIA_PREVIOUS_COMMAND_ID: {
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPreviousCallback(apCommandObj);
break;
}
case ZCL_MEDIA_REWIND_COMMAND_ID: {


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaPreviousCallback(apCommandObj);
break;
}
case ZCL_MEDIA_REWIND_COMMAND_ID: {
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaRewindCallback(apCommandObj);
break;
}
case ZCL_MEDIA_SKIP_BACKWARD_COMMAND_ID: {


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaRewindCallback(apCommandObj);
break;
}
case ZCL_MEDIA_SKIP_BACKWARD_COMMAND_ID: {
// We are using TLVUnpackError and TLVError here since both of them can be CHIP_END_OF_TLV
// When TLVError is CHIP_END_OF_TLV, it means we have iterated all of the items, which is not a real error.
// Any error value TLVUnpackError means we have received an illegal value.
CHIP_ERROR TLVError = CHIP_NO_ERROR;
CHIP_ERROR TLVUnpackError = CHIP_NO_ERROR;
uint64_t deltaPositionMilliseconds;


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@woody-apple
Copy link
Contributor

Marking hotfix to fix the tree.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfMediaPlaybackClusterMediaStopCallback(apCommandObj);
break;
}
default: {
// Unrecognized command ID, error status will apply.
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kNotFound,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogError(Zcl, "Unknown command %" PRIx16 " for cluster %" PRIx16, aCommandId, ZCL_MEDIA_PLAYBACK_CLUSTER_ID);
break;
}


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5542): The cluster handlers should accept a ByteSpan for all string types.

// TODO(#5542): The cluster handlers should accept a ByteSpan for all string types.
TLVUnpackError = aDataTlv.GetDataPtr(match);
if (CHIP_NO_ERROR == TLVUnpackError)
{
matchExists = true;
validArgumentCount++;
}
break;


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5542): The cluster handlers should accept a ByteSpan for all string types.

// TODO(#5542): The cluster handlers should accept a ByteSpan for all string types.
TLVUnpackError = aDataTlv.GetDataPtr(data);
if (CHIP_NO_ERROR == TLVUnpackError)
{
dataExists = true;
validArgumentCount++;
}
break;
default:
// Unsupported tag, ignore it.
ChipLogProgress(Zcl, "Unknown TLV tag during processing.");


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5590) We should encode a response of status code for invalid TLV.

// TODO(#5590) We should encode a response of status code for invalid TLV.
if (CHIP_NO_ERROR == TLVError && CHIP_NO_ERROR == TLVUnpackError && 2 == validArgumentCount)
{
// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfTargetNavigatorClusterNavigateTargetCallback(apCommandObj, target, const_cast<uint8_t *>(data));
}
else
{
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kBadRequest,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogProgress(


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@todo
Copy link

todo bot commented May 5, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
emberAfTargetNavigatorClusterNavigateTargetCallback(apCommandObj, target, const_cast<uint8_t *>(data));
}
else
{
apCommandObj->AddStatusCode(nullptr, Protocols::SecureChannel::GeneralStatusCode::kBadRequest,
Protocols::SecureChannel::Id, Protocols::SecureChannel::kProtocolCodeGeneralFailure);
ChipLogProgress(
Zcl, "Failed to dispatch command, %d/%" PRIu32 " arguments parsed, TLVError=%" PRIu32 ", UnpackError=%" PRIu32,
2, validArgumentCount, TLVError, TLVUnpackError);
}


This comment was generated by todo based on a TODO comment in eee7e1c in #6483. cc @vivien-apple.

@woody-apple woody-apple merged commit ea5b53b into project-chip:master May 5, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants