ESP32: Fix compilation of temperature-measurement-app and lock-app #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vivien-apple PTAL |
woody-apple
approved these changes
May 5, 2021
|
Build failure, marking as hotfix |
bzbarsky-apple
approved these changes
May 5, 2021
dhrishi
force-pushed
the
esp32/temp_app_fix
branch
from
ec6fcd1 to
e2beb04
Compare
saurabhst
approved these changes
May 5, 2021
|
Checked the lock-app for ESP32 and added the fix for that as well. |
dhrishi
changed the title
Remove inclusion of unwanted header file DataModelHandler.h. The compilation fails as this file is now moved to "src/app/util"
dhrishi
force-pushed
the
esp32/temp_app_fix
branch
from
e2beb04 to
6ee4078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inclusion of unwanted header file DataModelHandler.h.
The compilation fails as this file is now moved to "src/app/util"