Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zap uint16 t for attribute store #6446

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

The current attribute store has a size attribute defined as uint8_t. This is not enough to store a certificate.

Summary of Changes

  • Replace uint8_t by uint16_t
  • Update gen/ folders

@woody-apple
Copy link
Contributor

@mspang @saurabhst ?

@vivien-apple vivien-apple force-pushed the ZAP_uint16_tForAttributeStore branch 2 times, most recently from a39829e to 26ff262 Compare May 4, 2021 16:21
@vivien-apple vivien-apple force-pushed the ZAP_uint16_tForAttributeStore branch from 26ff262 to d5132d2 Compare May 4, 2021 17:26
@github-actions
Copy link

github-actions bot commented May 4, 2021

Size increase report for "nrfconnect-example-build" from dab17fb

File Section File VM
chip-lock.elf device_handles 4 4
chip-lock.elf text -36 -36
chip-lock.elf rodata -48 -48
chip-lighting.elf rodata -112 -116
chip-lighting.elf text -128 -128
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_str,0,48
.debug_loc,0,16
.debug_line,0,9
device_handles,4,4
.debug_info,0,-9
.symtab,0,-32
text,-36,-36
rodata,-48,-48

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_str,0,48
.debug_loc,0,16
.debug_line,0,9
.debug_info,0,-9
.symtab,0,-32
rodata,-116,-112
text,-128,-128


@github-actions
Copy link

github-actions bot commented May 4, 2021

Size increase report for "esp32-example-build" from dab17fb

File Section File VM
chip-all-clusters-app.elf .flash.text -76 -76
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_str,0,48
.debug_line,0,6
.xt.prop._ZTVN4chip24LifetimePersistedCounterE,0,-2
.debug_loc,0,-60
.flash.text,-76,-76

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 30daae2 into project-chip:master May 5, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request May 5, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request May 5, 2021
yunhanw-google added a commit that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants