-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zap uint16 t for attribute store #6446
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_uint16_tForAttributeStore
May 5, 2021
Merged
Zap uint16 t for attribute store #6446
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_uint16_tForAttributeStore
May 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
shana-apple
May 4, 2021 13:41
msandstedt
approved these changes
May 4, 2021
mspang
approved these changes
May 4, 2021
andy31415
approved these changes
May 4, 2021
vivien-apple
force-pushed
the
ZAP_uint16_tForAttributeStore
branch
2 times, most recently
from
May 4, 2021 16:21
a39829e
to
26ff262
Compare
vivien-apple
force-pushed
the
ZAP_uint16_tForAttributeStore
branch
from
May 4, 2021 17:26
26ff262
to
d5132d2
Compare
Size increase report for "nrfconnect-example-build" from dab17fb
Full report output
|
Size increase report for "esp32-example-build" from dab17fb
Full report output
|
woody-apple
approved these changes
May 4, 2021
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
May 5, 2021
This reverts commit 30daae2.
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
May 5, 2021
This reverts commit 30daae2.
yunhanw-google
added a commit
that referenced
this pull request
May 5, 2021
This reverts commit 30daae2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current attribute store has a size attribute defined as
uint8_t
. This is not enough to store a certificate.Summary of Changes
uint8_t
byuint16_t
gen/
folders