Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exit: return idiom from src/inet and src/transport #5914

Closed
wants to merge 2 commits into from
Closed

Remove exit: return idiom from src/inet and src/transport #5914

wants to merge 2 commits into from

Commits on Apr 9, 2021

  1. Remove exit: return idiom from src/inet and src/transport 

    #### Problem

The `Exit` group of error-handling macros inhibit scoping, and
are unnecessary when there is no cleanup at the `exit:` label.

#### Summary of Changes

- Remove `exit: return` idiom from src/lib, replacing `Exit` macros
  with corresponding `Return` macros.
- Incidentally fixed a bug in `RawEndPoint::BindInterface` and
  `UDPEndPoint::BindInterface` that could leave the LwIP lock held
  by calling `SuccessOrExit()` within a locked section.
    @kpschoedel
    kpschoedel committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e076c6e View commit details
    Browse the repository at this point in the history

  2. fix nrfconnect build

    @kpschoedel
    kpschoedel committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    be0ecae View commit details
    Browse the repository at this point in the history