Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First implementation of iOS CHIP.framework and iOS code parser app #537

Merged
merged 7 commits into from
May 5, 2020
Merged

First implementation of iOS CHIP.framework and iOS code parser app #537

merged 7 commits into from
May 5, 2020

Conversation

shana-apple
Copy link
Contributor

@shana-apple shana-apple commented Apr 29, 2020 •
edited
Loading

First implementation of CHIP framework and a demo app

sagar-apple
sagar-apple reviewed Apr 29, 2020
View reviewed changes
src/inet/Makefile.am Outdated Show resolved Hide resolved
sagar-apple
sagar-apple reviewed Apr 29, 2020
View reviewed changes
Copy link
Contributor

@sagar-apple sagar-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the Framework use CHP instead of CHIP in a lot of places? Can we just update it to use CHIP?

sagar-apple
sagar-apple reviewed Apr 29, 2020
View reviewed changes
Makefile-iOS Outdated Show resolved Hide resolved
sagar-apple
sagar-apple reviewed Apr 29, 2020
View reviewed changes
Makefile-iOS Outdated Show resolved Hide resolved
sagar-apple
sagar-apple reviewed Apr 29, 2020
View reviewed changes
Makefile-iOS Outdated Show resolved Hide resolved
@sagar-apple
Copy link
Contributor

sagar-apple commented Apr 29, 2020 •
edited
Loading

Why does the Framework use CHP instead of CHIP in a lot of places? Can we just update it to use CHIP?

I see that this might be to avoid collisions with CHIP files. Maybe pre/append them with -interface or iOS or something to make it clearer. Maybe others have better suggestions.

@gerickson
Copy link
Contributor

Why does the Framework use CHP instead of CHIP in a lot of places? Can we just update it to use CHIP?

+1

@gerickson
Copy link
Contributor

Overall, this seems like a great start (and an even better demo on Tuesday morning). Before we land this, we should map out what iOS apps, iOS frameworks, macOS apps, macOS frameworks, Android apps, Android ADKs, etc. look like in the tree and provide a sane, scalable structure so that it all coexists nicely.

@rwalker-apple, any thoughts? Do we partition by language, platform, OS?

rwalker-apple
rwalker-apple suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, Shana!

can we please rename "iOS Framework" to CHIP_framework? maybe put it under src, too?

@shana-apple
Copy link
Contributor Author

Why does the Framework use CHP instead of CHIP in a lot of places? Can we just update it to use CHIP?

+1

@shana-apple shana-apple reopened this Apr 29, 2020
@shana-apple shana-apple reopened this Apr 29, 2020
@shana-apple shana-apple marked this pull request as ready for review April 29, 2020 19:38
@woody-apple
Copy link
Contributor

@jelderton @saurabhst ?

rwalker-apple
rwalker-apple previously requested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my naming concerns have been addressed

src/CHIP_Framework_iOS/CHIP/CHIP/CHIPError.mm Show resolved Hide resolved
@woody-apple woody-apple mentioned this pull request May 5, 2020
Closed
@woody-apple woody-apple dismissed rwalker-apple’s stale review May 5, 2020 19:51

Following up with an issue

@woody-apple woody-apple merged commit 9ffc90f into project-chip:master May 5, 2020
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 24, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
fcde66b 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
f45fd7a 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 18, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
32ca8e8 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Jun 23, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
eb5bdcb 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Sep 1, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
8c16bf5 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
f3a9d29 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 25, 2023
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
d6c8a83 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
a4252ab 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Jan 18, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
0946e6c 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
cca116b 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
490183c 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
b90e549 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
db5f972 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
5c0e235 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
561a006 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@jmartinez-silabs
Pull request project-chip#537: Added chip-tool tests section to UMB u…
663d517 
…ser guide

Merge in WMN_TOOLS/matter from umb_user_guide_chip_tool_tests to silabs

Squashed commit of the following:

commit 6cc0d5904c62b03530afe63b8adcef6183bdeb5c
Author: Milind Dumbare <milind.dumbare@silabs.com>
Date:   Mon Jan 30 12:36:26 2023 +0100

    Added chip-tool tests section to UMB user guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerickson gerickson gerickson left review comments

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@jelderton jelderton jelderton approved these changes

@rwalker-apple rwalker-apple rwalker-apple left review comments

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@bhaskar-apple bhaskar-apple Awaiting requested review from bhaskar-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@shana-apple @sagar-apple @gerickson @rwalker-apple @bhaskar-apple @woody-apple @saurabhst @BroderickCarlin @jelderton @restyled-commits