Make the ESP32 Echo Server use Inet #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
gerickson
reviewed
Apr 29, 2020
| } | ||
| ESP_LOGI(TAG, "Socket created"); | ||
| ESP_LOGI(TAG, "UDP packet received from %s:%u to %s:%u (%zu bytes)", src_addr, packet_info->SrcPort, dest_addr, | ||
| packet_info->DestPort, static_cast<size_t>(buffer->DataLength())); |
There was a problem hiding this comment.
Minor nit: rather than calling buffer->DataLength() repeatedly, I'd assign it to a const value at the top of the block and then use that const value.
There was a problem hiding this comment.
Sounds good. I'll push a follow-up.
gerickson
approved these changes
Apr 29, 2020
pan-apple
reviewed
Apr 29, 2020
| static const char * TAG = "echo_client"; | ||
| static const char * PAYLOAD = "Message from echo client!"; | ||
|
|
||
| static void udp_client_task(void * pvParameters) |
There was a problem hiding this comment.
Do we plan to use InetLayer for client (maybe in a follow on PR)?
There was a problem hiding this comment.
I intentionally chose not to use Inet on the first pass of this Client. I wanted the client to emulate a pure socket echo client. Mainly to demonstrate that the Server will respond to anything, not just things delivered via CHIP components.
Like you suggested, I might migrate it in a follow-up PR if we see fit.
|
LGTM |
woody-apple
approved these changes
Apr 29, 2020
jelderton
approved these changes
Apr 29, 2020
saurabhst
approved these changes
Apr 29, 2020
BroderickCarlin
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ESP32 WiFi-echo example doesn't use the InetLayer and so doesn't pass signals through the CHIP stack
Summary of Changes
fixes #533