-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pairing of multiple admins with a device #4738
Conversation
This code is temporary, and must be updated to use the Cluster API.connectedhomeip/src/app/server/Server.cpp Lines 181 to 191 in 6a67aab
This comment was generated by todo based on a
|
This code is temporary, and must be updated to use the Cluster API.connectedhomeip/src/controller/CHIPDevice.cpp Lines 253 to 263 in 6a67aab
This comment was generated by todo based on a
|
|
Some of the failures are in unrelated code. Maybe a rebase is needed..
|
d4e007e
to
394d295
Compare
394d295
to
03192c5
Compare
The following class is setting the discriminator in Persistent Storage. This isconnectedhomeip/src/app/server/Server.cpp Lines 66 to 76 in 81f21bb
This comment was generated by todo based on a
|
@saurabhst, do you have any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Problem
Missing implementation for adding multiple administrator to a device.
Summary of Changes
This PR adds mechanism to trigger opening pairing window on a previously paired device. It generates a temporary manual setup code that the second admin can use to pair with the device. Alternatively, the first admin can let the second admin use the original setup code from the device.
The PR adds a bespoke/temporary implementation of commissioning cluster. This will eventually be moved to the code-generated implementation. The code is marked with TODO, and corresponding issue.