Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open BLE advertisement only for the duration of pairing #4568

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

The device keeps advertisement on BLE even after the pairing process is complete.

Summary of Changes

Restrict BLE advertisement for the duration of pairing. The advertisement will start when the rendezvous session is opened on the device, and closed after a successful or unsuccessful pairing.

@pan-apple pan-apple force-pushed the ble-advertisement-window branch from 8f937ad to c5a84e8 Compare January 30, 2021 03:57
@github-actions
Copy link

Size increase report for "esp32-example-build" from a83086a

File Section File VM
chip-all-clusters-app.elf .flash.text 176 176
chip-all-clusters-app.elf .flash.rodata 48 48
chip-all-clusters-app.elf [2 Others] -48 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,3479
.debug_line,0,957
.debug_str,0,939
.strtab,0,757
.debug_loc,0,623
.shstrtab,0,567
.symtab,0,352
.debug_frame,0,288
.debug_ranges,0,176
.flash.text,176,176
.xt.prop._ZNK4chip31RendezvousAdvertisementDelegate18StartAdvertisementEv,0,128
.debug_abbrev,0,98
.debug_aranges,0,96
.xt.lit._ZN4chip9Transport5TupleIJNS0_3UDPES2_EED5Ev,0,80
.xt.prop._ZN4chip31RendezvousAdvertisementDelegateD0Ev,0,76
.xt.prop._ZN4chip31RendezvousAdvertisementDelegateD2Ev,0,76
.xt.prop._ZNK4chip31RendezvousAdvertisementDelegate17StopAdvertisementEv,0,76
.xt.prop._ZTVN4chip31RendezvousAdvertisementDelegateE,0,52
.flash.rodata,48,48
.xt.lit._ZNK4chip31RendezvousAdvertisementDelegate18StartAdvertisementEv,0,48
[2 Others],8,-48


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from a83086a

File Section File VM
chip-lock.elf text 144 144
chip-lock.elf rodata 48 48
chip-lock.elf bss 0 8
chip-lock.elf datas 4 4
chip-lock.elf devices 4 4
chip-lock.elf [LOAD #3 [RW]] 0 -8
chip-lighting.elf text 148 148
chip-lighting.elf rodata 48 48
chip-lighting.elf bss 0 8
chip-lighting.elf datas 4 4
chip-lighting.elf devices 4 4
chip-lighting.elf shell_root_cmds_sections -4 -4
chip-lighting.elf [LOAD #3 [RW]] 0 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,3473
.debug_str,0,939
.strtab,0,757
.debug_loc,0,685
.debug_line,0,541
.symtab,0,416
.debug_frame,0,216
.debug_ranges,0,192
text,144,144
.debug_abbrev,0,130
.debug_aranges,0,96
rodata,48,48
bss,8,0
datas,4,4
devices,4,4
.shstrtab,0,-1
[LOAD #3 [RW]],-8,0

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,3473
.debug_str,0,939
.strtab,0,757
.debug_loc,0,685
.debug_line,0,541
.symtab,0,416
.debug_frame,0,216
.debug_ranges,0,192
text,148,148
.debug_abbrev,0,130
.debug_aranges,0,96
rodata,48,48
bss,8,0
datas,4,4
devices,4,4
.shstrtab,0,-1
shell_root_cmds_sections,-4,-4
[LOAD #3 [RW]],-8,0

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit 9bfbf41 into project-chip:master Feb 1, 2021
@pan-apple pan-apple deleted the ble-advertisement-window branch February 1, 2021 22:57
austinh0 pushed a commit to austinh0/connectedhomeip that referenced this pull request Feb 3, 2021
…#4568)

* Open BLE advertisement only for the duration of pairing

* fix Android build issue

* add device layer checks

* Add delegate to start/stop advertisement
austinh0 pushed a commit to austinh0/connectedhomeip that referenced this pull request Feb 3, 2021
…#4568)

* Open BLE advertisement only for the duration of pairing

* fix Android build issue

* add device layer checks

* Add delegate to start/stop advertisement
austinh0 pushed a commit to austinh0/connectedhomeip that referenced this pull request Feb 4, 2021
…#4568)

* Open BLE advertisement only for the duration of pairing

* fix Android build issue

* add device layer checks

* Add delegate to start/stop advertisement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants