-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open BLE advertisement only for the duration of pairing #4568
Merged
andy31415
merged 4 commits into
project-chip:master
from
pan-apple:ble-advertisement-window
Feb 1, 2021
Merged
Open BLE advertisement only for the duration of pairing #4568
andy31415
merged 4 commits into
project-chip:master
from
pan-apple:ble-advertisement-window
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst and
woody-apple
January 29, 2021 16:54
saurabhst
approved these changes
Jan 29, 2021
woody-apple
approved these changes
Jan 29, 2021
andy31415
reviewed
Jan 29, 2021
pan-apple
force-pushed
the
ble-advertisement-window
branch
from
January 30, 2021 03:57
8f937ad
to
c5a84e8
Compare
Size increase report for "esp32-example-build" from a83086a
Full report output
|
Size increase report for "nrfconnect-example-build" from a83086a
Full report output
|
andy31415
approved these changes
Feb 1, 2021
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…#4568) * Open BLE advertisement only for the duration of pairing * fix Android build issue * add device layer checks * Add delegate to start/stop advertisement
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
…#4568) * Open BLE advertisement only for the duration of pairing * fix Android build issue * add device layer checks * Add delegate to start/stop advertisement
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
…#4568) * Open BLE advertisement only for the duration of pairing * fix Android build issue * add device layer checks * Add delegate to start/stop advertisement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The device keeps advertisement on BLE even after the pairing process is complete.
Summary of Changes
Restrict BLE advertisement for the duration of pairing. The advertisement will start when the rendezvous session is opened on the device, and closed after a successful or unsuccessful pairing.