Fix K32W platform build #4556
Merged
Fix K32W platform build #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following errors with the K32W build:
ERROR at //src/platform/K32W/BLEManagerImpl.cpp:29:11: Include not allowed.
#include <crypto/CHIPCryptoPAL.h>
^---------------------
It is not in any dependency of
//src/platform:platform
The include file is in the target(s):
//src/crypto:crypto
which should somehow be reachable.
and
../../src/platform/K32W/BLEManagerImpl.cpp: In member function 'void chip::DeviceLayer::Internal::BLEManagerImpl::HandleRXCharWrite(chip::DeviceLayer::Internal::BLEManagerImpl::blekw_msg_t*)':
../../src/platform/K32W/BLEManagerImpl.cpp:1097:11: error: 'PacketBuffer' has not been declared
1097 | buf = PacketBuffer::NewWithAvailableSize(writeLen);
| ^~~~~~~~~~~~
../../src/platform/K32W/BLEManagerImpl.cpp:1115:49: error: 'class chip::System::PacketBufferHandle' has no member named 'Release_ForNow'
1115 | event.CHIPoBLEWriteReceived.Data = buf.Release_ForNow();
|
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
saurabhst,
vivien-apple,
woody-apple and
yufengwangca
kpschoedel
approved these changes
Jan 28, 2021
woody-apple
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
@mspang Can you please file an issue (if you haven't already) for CI for this?
|
Forcing this in, given hot fix. |
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
This fixes the following errors with the K32W build:
ERROR at //src/platform/K32W/BLEManagerImpl.cpp:29:11: Include not allowed.
#include <crypto/CHIPCryptoPAL.h>
^---------------------
It is not in any dependency of
//src/platform:platform
The include file is in the target(s):
//src/crypto:crypto
which should somehow be reachable.
and
../../src/platform/K32W/BLEManagerImpl.cpp: In member function 'void chip::DeviceLayer::Internal::BLEManagerImpl::HandleRXCharWrite(chip::DeviceLayer::Internal::BLEManagerImpl::blekw_msg_t*)':
../../src/platform/K32W/BLEManagerImpl.cpp:1097:11: error: 'PacketBuffer' has not been declared
1097 | buf = PacketBuffer::NewWithAvailableSize(writeLen);
| ^~~~~~~~~~~~
../../src/platform/K32W/BLEManagerImpl.cpp:1115:49: error: 'class chip::System::PacketBufferHandle' has no member named 'Release_ForNow'
1115 | event.CHIPoBLEWriteReceived.Data = buf.Release_ForNow();
|
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 3, 2021
This fixes the following errors with the K32W build:
ERROR at //src/platform/K32W/BLEManagerImpl.cpp:29:11: Include not allowed.
#include <crypto/CHIPCryptoPAL.h>
^---------------------
It is not in any dependency of
//src/platform:platform
The include file is in the target(s):
//src/crypto:crypto
which should somehow be reachable.
and
../../src/platform/K32W/BLEManagerImpl.cpp: In member function 'void chip::DeviceLayer::Internal::BLEManagerImpl::HandleRXCharWrite(chip::DeviceLayer::Internal::BLEManagerImpl::blekw_msg_t*)':
../../src/platform/K32W/BLEManagerImpl.cpp:1097:11: error: 'PacketBuffer' has not been declared
1097 | buf = PacketBuffer::NewWithAvailableSize(writeLen);
| ^~~~~~~~~~~~
../../src/platform/K32W/BLEManagerImpl.cpp:1115:49: error: 'class chip::System::PacketBufferHandle' has no member named 'Release_ForNow'
1115 | event.CHIPoBLEWriteReceived.Data = buf.Release_ForNow();
|
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Feb 4, 2021
This fixes the following errors with the K32W build:
ERROR at //src/platform/K32W/BLEManagerImpl.cpp:29:11: Include not allowed.
#include <crypto/CHIPCryptoPAL.h>
^---------------------
It is not in any dependency of
//src/platform:platform
The include file is in the target(s):
//src/crypto:crypto
which should somehow be reachable.
and
../../src/platform/K32W/BLEManagerImpl.cpp: In member function 'void chip::DeviceLayer::Internal::BLEManagerImpl::HandleRXCharWrite(chip::DeviceLayer::Internal::BLEManagerImpl::blekw_msg_t*)':
../../src/platform/K32W/BLEManagerImpl.cpp:1097:11: error: 'PacketBuffer' has not been declared
1097 | buf = PacketBuffer::NewWithAvailableSize(writeLen);
| ^~~~~~~~~~~~
../../src/platform/K32W/BLEManagerImpl.cpp:1115:49: error: 'class chip::System::PacketBufferHandle' has no member named 'Release_ForNow'
1115 | event.CHIPoBLEWriteReceived.Data = buf.Release_ForNow();
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following errors with the K32W build:
ERROR at //src/platform/K32W/BLEManagerImpl.cpp:29:11: Include not allowed.
#include <crypto/CHIPCryptoPAL.h>
^---------------------
It is not in any dependency of
//src/platform:platform
The include file is in the target(s):
//src/crypto:crypto
which should somehow be reachable.
and
../../src/platform/K32W/BLEManagerImpl.cpp: In member function 'void chip::DeviceLayer::Internal::BLEManagerImpl::HandleRXCharWrite(chip::DeviceLayer::Internal::BLEManagerImpl::blekw_msg_t*)':
../../src/platform/K32W/BLEManagerImpl.cpp:1097:11: error: 'PacketBuffer' has not been declared
1097 | buf = PacketBuffer::NewWithAvailableSize(writeLen);
| ^~~~~~~~~~~~
../../src/platform/K32W/BLEManagerImpl.cpp:1115:49: error: 'class chip::System::PacketBufferHandle' has no member named 'Release_ForNow'
1115 | event.CHIPoBLEWriteReceived.Data = buf.Release_ForNow();
|