-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed logs from the configuration manager getter methods. #4495
Removed logs from the configuration manager getter methods. #4495
Conversation
Getter methods of the Configuration Manager contain logs, what results in printing the same logs multiple times on the console. * Removed logs from Configuration Manager getter methods * Added printing information about setup pin code and setup discriminator to the LogDeviceConfig() method * Removed if CHIP_PROGRESS_LOGGING condition before LogDeviceConfig() implementation, as it should be checked before calling it (and is already used there) * Created interface to the LogDeviceConfig() to allow using it in samples * Removed returning setupPinCode from the QRCodeUtil::GetQRCode() method. * Removed printing setup pin code from the PrintQRCode method(). * Aligned nrfconnect, EFR32 and QPG6100 samples, because of the QRCodeUtil API changes.
This PR is changing QRCodeUtil API a little bit, so I wanted to align all samples, which could be affected by this change. Could some of you @jmartinez-silabs @jepenven-silabs @tima-q review EFR32 and QPG6100 samples changes to make sure that any regressions will not appear? |
Size increase report for "esp32-example-build" from 5dcbd40
Full report output
|
Size increase report for "nrfconnect-example-build" from 5dcbd40
Full report output
|
@kkasperczyk-no looks fine after compiling in your changes. Grouping the info makes it more readable as well. Thanks! |
Everything seems fine on our side as well |
…chip#4495) * Removed logs from the configuration manager getter methods. Getter methods of the Configuration Manager contain logs, what results in printing the same logs multiple times on the console. * Removed logs from Configuration Manager getter methods * Added printing information about setup pin code and setup discriminator to the LogDeviceConfig() method * Removed if CHIP_PROGRESS_LOGGING condition before LogDeviceConfig() implementation, as it should be checked before calling it (and is already used there) * Created interface to the LogDeviceConfig() to allow using it in samples * Removed returning setupPinCode from the QRCodeUtil::GetQRCode() method. * Removed printing setup pin code from the PrintQRCode method(). * Aligned nrfconnect, EFR32 and QPG6100 samples, because of the QRCodeUtil API changes. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
…chip#4495) * Removed logs from the configuration manager getter methods. Getter methods of the Configuration Manager contain logs, what results in printing the same logs multiple times on the console. * Removed logs from Configuration Manager getter methods * Added printing information about setup pin code and setup discriminator to the LogDeviceConfig() method * Removed if CHIP_PROGRESS_LOGGING condition before LogDeviceConfig() implementation, as it should be checked before calling it (and is already used there) * Created interface to the LogDeviceConfig() to allow using it in samples * Removed returning setupPinCode from the QRCodeUtil::GetQRCode() method. * Removed printing setup pin code from the PrintQRCode method(). * Aligned nrfconnect, EFR32 and QPG6100 samples, because of the QRCodeUtil API changes. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Problem
Getter methods of the Configuration Manager contain logs, what results in printing the same logs multiple times on the console.
Summary of Changes