Move build/config to config #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2020 08:05
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
gerickson
approved these changes
Apr 20, 2020
jelderton
approved these changes
Apr 20, 2020
BroderickCarlin
approved these changes
Apr 20, 2020
rwalker-apple
changed the title
turon
reviewed
Apr 20, 2020
| @@ -80,7 +80,7 @@ AC_CONFIG_AUX_DIR([build/autoconf]) | |||
| # Tell autoconf where to find auxilliary M4 macros | |||
| # Note that nlbuild-autotools has macros in two subdirs, for local vs third-party scripts | |||
| # | |||
| AC_CONFIG_MACRO_DIRS([build/autoconf/m4 third_party/nlbuild-autotools/repo/third_party/autoconf/m4 third_party/nlbuild-autotools/repo/autoconf/m4]) | |||
| AC_CONFIG_MACRO_DIRS([build/autoconf/m4 autoconf/m4 third_party/nlbuild-autotools/repo/third_party/autoconf/m4 third_party/nlbuild-autotools/repo/autoconf/m4]) | |||
There was a problem hiding this comment.
What is the extra autoconf/m4 needed for?
There was a problem hiding this comment.
we've written some CHIP-specific autoconf helpers that we add to the mix. those live in autoconf/m4
prior to this change, we were mixing those in with the autoconf-supplied --missing ones.
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Dec 19, 2022
…e due to outdated log statement
Merge in WMN_TOOLS/matter from bugfix/wifi_window_app_build_failure_fix to RC_1.0.2-1.0
Squashed commit of the following:
commit 32d5a05f52f1cb7a177582085a9d4f75be0b6bc1
Author: Manav Mehta <Manav.Mehta@silabs.com>
Date: Tue Dec 13 04:31:14 2022 +0000
Fixed build failure due to outdated log statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
build/ is a mix of git files and build output
Summary of Changes
moving git files out of build
fixes #405