Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell]:Start CHIP event-loop by default during initialization. #4185

Merged
merged 2 commits into from
Dec 12, 2020
Merged

[shell]:Start CHIP event-loop by default during initialization. #4185

merged 2 commits into from
Dec 12, 2020

Conversation

yufengwangca
Copy link
Contributor

Problem

Currently, shell does not start event-loop by default, we need to first issue 'start' command to run device layer event loop before issue other device commands. And 'start' command is always needed.

Summary of Changes

Start CHIP event-loop by default during initialization.

@yufengwangca yufengwangca changed the title Start CHIP event-loop by default during initialization. [shell]:Start CHIP event-loop by default during initialization. Dec 11, 2020
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 4bfade2

File Section File VM
chip-shell.elf text 60 60
chip-shell.elf rodata -8 -4
chip-shell.elf log_const_sections -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,11424
.debug_str,0,3175
.debug_line,0,2038
.debug_abbrev,0,1822
.debug_loc,0,177
.strtab,0,111
.symtab,0,64
text,60,60
.debug_frame,0,36
.debug_aranges,0,32
.debug_ranges,0,16
.shstrtab,0,1
rodata,-4,-8
log_const_sections,-12,-12

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit 8a75ed7 into project-chip:master Dec 12, 2020
@yufengwangca yufengwangca deleted the pr/shell/init branch December 12, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants