Resurrect 'SetUdpListenPort' on 'ChipDeviceController' #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Controller_SetUdpListenPort
branch
from
6381208
to
49f48ef
Compare
|
For the record I need it for #3675 |
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
rwalker-apple
approved these changes
Dec 3, 2020
jelderton
approved these changes
Dec 4, 2020
vivien-apple
force-pushed
the
Controller_SetUdpListenPort
branch
from
49f48ef
to
eac3b07
Compare
andy31415
reviewed
Dec 7, 2020
andy31415
reviewed
Dec 7, 2020
vivien-apple
force-pushed
the
Controller_SetUdpListenPort
branch
from
eac3b07
to
11fb7dc
Compare
vivien-apple
force-pushed
the
Controller_SetUdpListenPort
branch
from
11fb7dc
to
01fb7ce
Compare
BroderickCarlin
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While landing #3630 the ability to configure the local port to listen to for messages has been broken.
This PR add it back on the new
ChipDeviceControllerAPI. This API is useful when you run both the server and the client on the same machine for example.Summary of Changes
SetUpdListenPorton the newChipDeviceControllerAPI