Enable HardPrivacy mode in the CameraDevice to enable optional attribute HardPrivacyModeOn. #40598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the hard privacy switch feature, which in turn enables the HardPrivacyModeOn optional attribute. The change is straightforward and correct. I've just pointed out a stale comment that should be updated to reflect the new behavior.
…ute HardPrivacyModeOn. This is to allow a successful wildcard read of all attributes on the AVSM cluster.
pidarped
force-pushed
the
enableHardPrivacyMode
branch
from
dcf3d7a to
4754b9d
Compare
|
PR #40598: Size comparison from 3b50b2e to 4754b9d Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40598 +/- ##
=======================================
Coverage 50.68% 50.68%
=======================================
Files 1350 1350
Lines 99234 99236 +2
Branches 12910 12910
=======================================
+ Hits 50295 50297 +2
Misses 48939 48939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marktrayer
approved these changes
Aug 14, 2025
yufengwangca
approved these changes
Aug 14, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Aug 19, 2025
…ute HardPrivacyModeOn. (project-chip#40598) This is to allow a successful wildcard read of all attributes on the AVSM cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is to allow a successful wildcard read of all attributes on the AVSM cluster.
Testing
./chip-tool any read-by-id 0x551 0xFFFFFFFF 1 1Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines