Skip to content

Enhance checks for OpenSSL #40579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

Alami-Amine
Copy link
Contributor

Summary

Testing

CI Testing

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the robustness of the OpenSSL certificate format verification by adding null pointer checks for the Subject Key Identifier (SKID) and Authority Key Identifier (AKID). The previous implementation could lead to a null pointer dereference and a potential crash if these optional extensions were not present in a certificate. The added checks correctly handle this case by verifying the pointers are not null before accessing their members. The change is correct and improves the stability of the code. I have no further comments.

@Alami-Amine Alami-Amine changed the title Enhance checks for OpenSSL [DRAFT] Testing do not merge Aug 14, 2025
@Alami-Amine Alami-Amine marked this pull request as draft August 14, 2025 09:04
@Alami-Amine Alami-Amine marked this pull request as ready for review August 14, 2025 13:13
@Alami-Amine Alami-Amine changed the title [DRAFT] Testing do not merge Enhance checks for OpenSSL Aug 14, 2025
@andy31415 andy31415 merged commit 4ca7325 into project-chip:v1.3-branch Aug 14, 2025
60 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants