[Android][Java]Bump Java version with 17 #40500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pullapprove
bot
added
review - pending
and removed
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the required Java version from 11 to 17 to support future Android Gradle Plugin versions. The changes are applied consistently across documentation and Docker build images. I've found one minor issue in the documentation where a reference to the old JDK version remains, which could cause confusion. After addressing this, the PR should be ready to merge.
| @@ -100,19 +100,19 @@ architecture: | |||
|
|
|||
| All Android projects utilize Gradle version 7.3.3 and JDK version 11.0. | |||
|
|
|||
| For developer using java 11 in MacOS, the JAVA can be configured as follows via | |||
| For developer using java 17 in MacOS, the JAVA can be configured as follows via | |||
There was a problem hiding this comment.
While this section is correctly updated to reference Java 17, the preceding sentence on line 101 still mentions that projects use JDK version 11.0. To avoid confusion for developers, please update line 101 to reflect the new requirement of JDK 17.
pgregorr-amazon
approved these changes
Aug 8, 2025
andy31415
reviewed
Aug 8, 2025
.github/workflows/full-android.yaml
Outdated
| @@ -33,7 +33,7 @@ jobs: | |||
| name: Run | |||
|
|
|||
| env: | |||
| JAVA_HOME: /usr/lib/jvm/java-11-openjdk-amd64/ | |||
There was a problem hiding this comment.
these yaml changes have to be taken out: only docker file changes should exist.
yunhanw-google
force-pushed
the
feature/java_17_android
branch
from
321a7c1 to
c851fd8
Compare
andy31415
approved these changes
Aug 8, 2025
andy31415
added
the
sdk-maintainer-approved
|
PR #40500: Size comparison from dc14833 to c851fd8 Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40500 +/- ##
=======================================
Coverage 51.00% 51.00%
=======================================
Files 1341 1341
Lines 98435 98435
Branches 12690 12690
=======================================
Hits 50202 50202
Misses 48233 48233 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soares-sergio
pushed a commit
to soares-sergio/connectedhomeip
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following https://developer.android.com/guide/practices/page-sizes#ndk-build_1, Starting November 1st, 2025, all new apps and updates to existing apps submitted to Google Play and targeting Android 15+ devices must support 16 KB page sizes on 64-bit devices.
We need upgrade AGP version with 8.5.1 that requires Java Development Kit (JDK) 17 to run Gradle
Related issues
Fixes #39871
Testing
local compilation
Readability checklist
N/A