[Closures] TC-CLCTRL-4.3 fix and minor changes #40465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a clean refactoring across multiple test files (TC_CLCTRL_4_2.py, TC_CLCTRL_4_3.py, TC_CLCTRL_4_4.py). The repeated calls to self.skip_step() have been consolidated into a single self.mark_step_range_skipped() call. This significantly improves code readability and maintainability by making the intent to skip a range of test steps more explicit and concise. The changes are consistent and well-executed.
|
PR #40465: Size comparison from 3176ce8 to 40dd661 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
fabian-imig
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40465 +/- ##
=======================================
Coverage 50.89% 50.89%
=======================================
Files 1341 1341
Lines 98435 98435
Branches 12724 12724
=======================================
+ Hits 50094 50095 +1
+ Misses 48341 48340 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #40465: Size comparison from 3176ce8 to 42ea1fe Full report (4 builds for cc32xx, nrfconnect, stm32)
|
…sting unnecessary state changes.
|
PR #40465: Size comparison from 3176ce8 to 536044f Increases above 0.2%:
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sorenmr
reviewed
Aug 7, 2025
sorenmr
approved these changes
Aug 7, 2025
|
PR #40465: Size comparison from 3176ce8 to 85c60c4 Full report (4 builds for cc32xx, nrfconnect, stm32)
|
|
PR #40465: Size comparison from 3176ce8 to 7c4b955 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
uebati-siegenia
approved these changes
Aug 7, 2025
|
PR #40465: Size comparison from 3176ce8 to f45c3e7 Increases above 0.2%:
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
AliTalebVelux
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues found in Matter 1.5 TE1 for the closure control test cases by improving step skipping logic and correcting test procedure flows. The changes focus on replacing multiple individual step skips with range-based skipping and adding missing test steps for proper latching behavior validation.
Key changes:
- Replace multiple
skip_step()calls withmark_step_range_skipped()for cleaner code - Add missing test steps (5m-5u, 9b-9i, 10b-10i) to properly test latching behavior scenarios
- Fix logic for conditional step execution based on latch control modes and current latch state
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| TC_CLCTRL_4_4.py | Replaces multiple skip_step calls with mark_step_range_skipped for cleaner step skipping |
| TC_CLCTRL_4_3.py | Major refactoring adding missing test steps and fixing latching behavior test logic |
| TC_CLCTRL_4_2.py | Replaces multiple skip_step calls with mark_step_range_skipped for consistency |
|
PR #40465: Size comparison from 9f409ce to cac9eb9 Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bufl-blum
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the changes necessary to fix issues found in Matter 1.5 TE1, skip ranges of steps instead of single steps..
Testplan PR:
Related issues
Testing
-> closure-app (362022f)
-> mfg-closure-dut