Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get temperature-measurement and all-clusters-app to use examples/comm… #4039

Merged
merged 1 commit into from
Dec 2, 2020

Commits on Dec 2, 2020

  1. Get temperature-measurement and all-clusters-app to use examples/comm…

    …on/chip-app-server
    
     #### Problem
    
    PR project-chip#3704 introduced a change where a `PeerAddress` is now required in order to start `RendezvousSession`.
    Sadly the multiple code paths bootstrapping `RendezvousSession` has not been updated.
    
    PR project-chip#4012 add a fix for some of the `examples/` but not for the `all-clusters-app` nor the `temperature-measurement-app`.
    
    To avoid such situation, this PR merge `examples/common/chip-app-server` and the custom code from `all-clusters-app` and `temperature-measurement-app`.
    
    One of the more discutable change of this PR (imo) is the code that moves the custom `Echo` mechanism from the `all-clusters-app` to `chip-app-server`. I was hoping to get rid of it before doing this change but the `all-clusters-app` and the `temperature-measurement-app` are broken since project-chip#3704 and this PR should fix that.
    Also I have a PR (mostly) ready once project-chip#3979 lands to get rid of this `Echo` specific code and replace it by a manufacturer specific `ping` command.
    
     #### Summary of Changes
     * Remove `EchoServer.cpp`, `RendezvousDeviceDelegate.cpp` and `include/RendezvousDeviceDelegate.h` from `all-clusters-app`
     * Remove `ResponseServer.cpp`, `RendezvousDeviceDelegate.cpp` and `include/RendezvousDeviceDelegate.h` from `temperature-measurement-app`
     * Introduce `chip-app-server/include/AppDelegate.h` in order to keep the behavior the `all-clusters-app` that turns on/off leds on different events. Maybe it should be converted to some types of `ChipDeviceEvent` or `CHIPCallback` at some point.
     * Fix `chip-app-server` to accomodate for the specifics of `all-clusters-app`
    vivien-apple committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    597c893 View commit details
    Browse the repository at this point in the history