Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Some conversions to use PacketBufferHandle #4031

Closed
wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Nov 30, 2020

A duplicate of #4011 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

kpschoedel and others added 3 commits November 27, 2020 09:31
#### Problem

Code should use `PacketBufferHandle` rather than `PacketBuffer *`.

#### Summary of Changes

- Converts remaining receive path in //src/inet and //src/transport.
- Converts most of //src/ble.
- Introduces Handle versions of the `AddToEnd`/`DetachTail` pair.

Part of issue #2707 - Figure out a way to express PacketBuffer ownership in the type system
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 515d2cc

File Section File VM
chip-lighting.elf text 340 340
chip-lighting.elf rodata 8 12
chip-lighting.elf shell_root_cmds_sections -4 -4
chip-lock.elf text 340 340
chip-lock.elf rodata 8 8
chip-lock.elf shell_root_cmds_sections -4 -4
chip-shell.elf text 272 272
chip-shell.elf rodata 16 12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,5691
.debug_line,0,1577
.debug_loc,0,1151
.debug_abbrev,0,772
.debug_ranges,0,624
text,340,340
.debug_str,0,337
.strtab,0,138
.debug_frame,0,104
.debug_aranges,0,24
rodata,12,8
.shstrtab,0,-2
shell_root_cmds_sections,-4,-4

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,5789
.debug_line,0,1571
.debug_loc,0,1147
.debug_abbrev,0,796
.debug_ranges,0,624
text,340,340
.debug_str,0,337
.strtab,0,138
.debug_frame,0,104
.debug_aranges,0,24
rodata,8,8
.shstrtab,0,2
shell_root_cmds_sections,-4,-4

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,4340
.debug_line,0,1441
.debug_loc,0,1180
.debug_abbrev,0,667
.debug_ranges,0,592
.debug_str,0,292
text,272,272
.strtab,0,88
.debug_frame,0,72
.debug_aranges,0,16
rodata,12,16


@restyled-io restyled-io bot closed this Nov 30, 2020
@restyled-io restyled-io bot deleted the restyled/pull-4011 branch November 30, 2020 22:35
@github-actions
Copy link

Size increase report for "esp32-example-build" from 515d2cc

File Section File VM
chip-all-clusters-app.elf .flash.text 276 276
chip-all-clusters-app.elf .flash.rodata 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,6554
.debug_line,0,3092
.debug_loc,0,1557
.debug_ranges,0,968
.debug_str,0,612
.debug_abbrev,0,333
.flash.text,276,276
.strtab,0,193
.debug_frame,0,72
.xt.prop._ZN4chip11DeviceLayer8Internal14BLEManagerImplD5Ev,0,52
.xt.lit._ZN4chip11DeviceLayer8Internal14BLEManagerImplD5Ev,0,48
.debug_aranges,0,24
.flash.rodata,4,4
.shstrtab,0,-1
[Unmapped],0,-4
.xt.prop._ZN4chip11DeviceLayer8Internal14BLEManagerImplD2Ev,0,-80


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants