Reduced docker image size by 800mb #402
Conversation
woody-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk and
tpmanley
as code owners
|
Note to self: Why is travis not running here...? |
|
So weird, here it is: https://travis-ci.com/github/project-chip/connectedhomeip |
| git \ | ||
| curl \ | ||
| jq \ | ||
| make \ | ||
| autoconf \ | ||
| automake \ | ||
| libtool \ | ||
| pkg-config \ | ||
| g++ \ | ||
| clang-9 \ | ||
| clang-format-9 \ | ||
| clang-tidy-9 \ | ||
| lcov \ | ||
| shellcheck \ | ||
| libssl-dev \ | ||
| unzip \ | ||
| wget \ | ||
| libmbedtls-dev \ |
There was a problem hiding this comment.
is this indentation from restyled? I had it this way to distinguish these are arguments to the previous command...
There was a problem hiding this comment.
It's from the standard VS Code docker file linter, I understand manual edits got here, but we need to have a way to codify these changes and automate the linting. I couldn't find any linters that were standard that can parse these chained commands well in a Dockerfile. If there's some you can find, please open an issue and I'll happily integrate it.
There was a problem hiding this comment.
maybe machines can't be trusted with human<=>human comms ;)
Problem
Builds in Travis are slow, as they seem to rate limit network bandwidth to docker hub... images can't be cached, so we should start to reduce image size if possible. Opening up an issue to generally do this, but this is a good first start.
More improvements needed here: #401
Summary of Changes
Clean up some caches, and delete zips that are large.