Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Implement the missing part of Exchange Header in Transport layer #4018

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Nov 30, 2020

A duplicate of #4017 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Nov 30, 2020
@restyled-io restyled-io bot closed this Nov 30, 2020
@restyled-io restyled-io bot deleted the restyled/pull-4017 branch November 30, 2020 02:30
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 7c17319

File Section File VM
chip-lock.elf shell_root_cmds_sections 8 8
chip-lock.elf text -104 -104
chip-lighting.elf shell_root_cmds_sections 8 8
chip-lighting.elf text -104 -104
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,3202
.debug_loc,0,216
.debug_line,0,136
.debug_abbrev,0,18
shell_root_cmds_sections,8,8
.debug_aranges,0,-8
.debug_frame,0,-20
.symtab,0,-32
.debug_ranges,0,-56
text,-104,-104
.debug_str,0,-184
.strtab,0,-400

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,3202
.debug_loc,0,224
.debug_line,0,136
.debug_abbrev,0,18
shell_root_cmds_sections,8,8
.debug_aranges,0,-8
.debug_frame,0,-20
.symtab,0,-32
.debug_ranges,0,-56
text,-104,-104
.debug_str,0,-184
.strtab,0,-400


@github-actions
Copy link

Size increase report for "esp32-example-build" from 7c17319

File Section File VM
chip-all-clusters-app.elf .flash.text 48 48
chip-all-clusters-app.elf .flash.rodata -24 -24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,2599
.debug_loc,0,401
.debug_line,0,276
.xt.prop._ZN4chip9Transport5TupleIJNS0_3UDPES2_EE11SendMessageERKNS_12PacketHeaderERKNS0_11PeerAddressEPNS_6System12PacketBufferE,0,136
.xt.lit._ZN4chip9Transport5TupleIJNS0_3UDPES2_EE11SendMessageERKNS_12PacketHeaderERKNS0_11PeerAddressEPNS_6System12PacketBufferE,0,128
.xt.prop._ZN4chip8Encoding12LittleEndian6Reader7RawReadIjEEvPT_,0,100
.flash.text,48,48
.shstrtab,0,48
.debug_abbrev,0,40
.xt.prop._ZN4chip8Encoding12LittleEndian6Reader7RawReadIhEEvPT_,0,40
.symtab,0,32
[Unmapped],0,24
[1 Others],0,1
.debug_aranges,0,-8
.debug_frame,0,-24
.flash.rodata,-24,-24
.debug_ranges,0,-56
.xt.lit._ZN4chip9Transport5TupleIJNS0_3UDPES2_EE11SendMessageERKNS_12PacketHeaderENS_8BitFlagsItNS_6Header10FlagValuesEEERKNS0_11PeerAddressEPNS_6System12PacketBufferE,0,-128
.xt.prop._ZN4chip9Transport5TupleIJNS0_3UDPES2_EE11SendMessageERKNS_12PacketHeaderENS_8BitFlagsItNS_6Header10FlagValuesEEERKNS0_11PeerAddressEPNS_6System12PacketBufferE,0,-136
.debug_str,0,-145
.strtab,0,-296


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants