Move Scene Cluster Specific callbaks from gen/callback* to src/app/sc… #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Nov 12, 2020
rwalker-apple
approved these changes
Nov 12, 2020
andy31415
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enes/scenes.h
Problem
CHIP
src/app/clustershave some interdependencies that is inherited from the SiLabs Plugins. #3464 does not have any information about plugins - only clusters. As a result it can not generate declarations/stubs for the plugins related methods.This PR moves some methods that belongs to the
Scenesplugin directly undersrc/app/clusters/scenes. The result is that other plugins that are dependent of theScenesplugin must directly#include <app/clusters/scenes/scenes.h>instead of relying on potential stubs.Summary of Changes
gen/callback*files tosrc/app/scenes/scenes.h#include <app/clusters/scenes/scenes.h>into the dependent plugins