Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata-tree from MetadaList Foo(path) to CHIP_ERROR Foo(path, ListBuilder &) #37127

Merged
merged 20 commits into from
Jan 23, 2025
Merged

Update metadata-tree from MetadaList Foo(path) to CHIP_ERROR Foo(path, ListBuilder &) #37127

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
742dc89
Append-only API update: use CHIP_ERROR and builders for MetadataTree
andy31415 Jan 20, 2025
92e448d
Fix includes
andy31415 Jan 20, 2025
c19a4fd
Remove odd comment
andy31415 Jan 20, 2025
48dc77c
ScopedSpan == ReadOnlyBuffer and Build == TakeBuffer
andy31415 Jan 20, 2025
066d2ea
Update src/app/InteractionModelEngine.cpp
andy31415 Jan 20, 2025
e37165e
Update src/app/clusters/descriptor/descriptor.cpp
andy31415 Jan 20, 2025
ea07467
Update src/app/clusters/descriptor/descriptor.cpp
andy31415 Jan 20, 2025
28a8640
Update src/app/clusters/descriptor/descriptor.cpp
andy31415 Jan 20, 2025
63dc63f
Update src/app/clusters/descriptor/descriptor.cpp
andy31415 Jan 20, 2025
c11bf30
Update src/app/clusters/descriptor/descriptor.cpp
andy31415 Jan 20, 2025
94cdf80
Update src/app/data-model-provider/MetadataList.cpp
andy31415 Jan 20, 2025
b052497
Replaced a lot of auto with const auto for readability
andy31415 Jan 20, 2025
f902249
Update src/app/clusters/microwave-oven-control-server/microwave-oven-…
andy31415 Jan 20, 2025
9e8d062
Merge branch 'append_only_api' of github.com:andy31415/connectedhomei…
andy31415 Jan 20, 2025
f122b28
Remove old comment
andy31415 Jan 20, 2025
6ae480e
Fix some typos
andy31415 Jan 20, 2025
52fbc7f
Fix typo
andy31415 Jan 20, 2025
eaf9f0c
Merge branch 'master' into append_only_api
andy31415 Jan 20, 2025
493950d
Update src/app/data-model-provider/MetadataTypes.h
andy31415 Jan 23, 2025
ded4d53
Merge branch 'master' into append_only_api
andreilitvin Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old comment
  • Loading branch information
@andy31415
andy31415 committed Jan 20, 2025
commit f122b28374708cae3dc6c622f5bb64e543eba32c
1 change: 0 additions & 1 deletion src/app/data-model-provider/MetadataList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ CHIP_ERROR GenericAppendOnlyBuffer::ReferenceExistingElementArrayRaw(const void
mBuffer = const_cast<uint8_t *>(static_cast<const uint8_t *>(buffer));
mElementCount = numElements;
// The assertions below are because we know the buffer is null/not allocated yet
// Not included because these seem to affect flash size surprisingly enough...
VerifyOrDie(mCapacity == 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, except above we set mCapacity to be nonzero on allocation failure, right? And we set mBufferIsAllocated to true too...

Copy link
Contributor Author

@andy31415 andy31415 Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oversight. Moved the return on alloc failure.

VerifyOrDie(!mBufferIsAllocated);
return CHIP_NO_ERROR;
Expand Down
Loading