[Chef] Create a ContactSensor to support LIT ICD （Linux Only) #37123
+5,927
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #37123: Size comparison from b02badf to 91317d1 Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #37123: Size comparison from b02badf to ef66372 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 21, 2025
| @@ -29,7 +29,7 @@ steps: | |||
| args: | |||
| - >- | |||
| perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt && | |||
| ./examples/chef/chef.py --build_all --build_exclude "noip|temperaturecontrolledcabinet" | |||
| ./examples/chef/chef.py --build_all --build_exclude "noip|temperaturecontrolledcabinet|ed3b19ec55" | |||
There was a problem hiding this comment.
ed3b... is not that friendly for users to read. Could we rename it as ICD maybe or use some different description?
Could we explain in comments why these are excluded?
There was a problem hiding this comment.
@andy31415 The icd is an cluster instead of a device type of an endpoint that we put it in the Chef's filename. So I just add some comments in the description. PTAL.
There was a problem hiding this comment.
The description comment doesn't help understand. I don't understand why we are keeping using the weird hashes in the device names. Nobody has actually done anything to keep track of those.
There was a problem hiding this comment.
It should not say ed3b19ec55 ... it should look like icd or something like that. An I want to exclude 12acb3d statement for example is not human reviewable and maintainable. It has no meaning as a number/hex code. Please use human readable strings.
There was a problem hiding this comment.
You can change the naming conventions if need be and mark things for ICD if that is important. However do not use hex "signatures" to identify things.
examples/chef/linux/main.cpp
Outdated
Comment on lines
33
to
37
| void notifyIcdActive(System::Layer * layer, void *) | ||
| { | ||
| ICDNotifier::GetInstance().NotifyNetworkActivityNotification(); | ||
| DeviceLayer::SystemLayer().StartTimer(chip::System::Clock::Milliseconds32(10000), notifyIcdActive, nullptr); | ||
| } |
There was a problem hiding this comment.
10s is not representative of real ICD devices.
There was a problem hiding this comment.
Yes, we need clear comments here, and make it runtime configurable. thanks
| #define CHIP_CONFIG_SYNCHRONOUS_REPORTS_ENABLED 1 | ||
|
|
||
| // ICD configurations | ||
| #define CHIP_CONFIG_ICD_IDLE_MODE_DURATION_SEC 30 |
There was a problem hiding this comment.
This is a very short interval. This should be configurable on the command line to allow flexibility.
There was a problem hiding this comment.
The method ICDConfigurationData::SetModeDurations allows to do that. It should be overridable from command line parameters beyond the starting default of this config.
There was a problem hiding this comment.
CHIP_CONFIG_ICD_IDLE_MODE_DURATION_SEC is better to be handled with runtime configuration. thanks
|
PR #37123: Size comparison from 577b3f2 to 0cc62c4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37123: Size comparison from 94a47ad to 387f7f2 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
| @@ -49,6 +57,10 @@ int main(int argc, char * argv[]) | |||
| cmd_app_server_init(); | |||
| #endif | |||
|
|
|||
| #if CHIP_CONFIG_ENABLE_ICD_CIP | |||
| DeviceLayer::SystemLayer().StartTimer(chip::System::Clock::Milliseconds32(CHIP_CONFIG_ICD_IDLE_MODE_DURATION_SEC*1000), notifyIcdActive, nullptr); | |||
There was a problem hiding this comment.
Having this timer here feels 100% wrong. Why is this in main? Why does it notify forever?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a Chef ContactSensor to support LIT ICD .
Testing
For example: the following command are setting ICD:
And it will send Check-In message every 15 seconds
The extra
Iis for enabling ICDThis Chef device
rootnode_contactsensor_ed3b19ec55is excluded from the build all script integrations/cloudbuild/chef.yaml since it requires additional compilation argument to enable ICD features.