[Zephyr] Remove redundant config and add implementation of POSIX API wrappers if necessary #37007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephyr now implements all required socket APIs, Remove redundant `CHIP_SYSTEM_CONFIG_USE_ZEPHYR_SOCKET_EXTENSIONS` config. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
|
Review changes with |
github-actions
bot
added
system
platform
nrf connect
zephyr
inet
config
test driver
nxp
maciejbaczmanski
force-pushed
the
matter_sockets_names
branch
2 times, most recently
from
f53c48f to
be25c9f
Compare
maciejbaczmanski
force-pushed
the
matter_sockets_names
branch
from
be25c9f to
825b220
Compare
`CONFIG_NET_SOCKETS_POSIX_NAMES` has been deprecated in Zephyr in favor of `CONFIG_POSIX_API`. `CONFIG_POSIX_API` enables additional functionalities other than sockets, resulting in increased footprint. This commit reuses `ZephyrSocket.h` to include Zephyr socket header and allow building with both configs disabled, adding neccessary wrappers.
maciejbaczmanski
force-pushed
the
matter_sockets_names
branch
from
825b220 to
5e3d939
Compare
andy31415
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Please add a ### Testing section describing how things were tested that this still works? What commands did you run (assuming manual testing) and what was observed. Did you test all affected platforms or only one/some and assumed the changes will work everywhere? Are all platform owners of the affected platforms aware of the change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zephyr now implements all required socket APIs, Remove redundant
CHIP_SYSTEM_CONFIG_USE_ZEPHYR_SOCKET_EXTENSIONSconfig.CONFIG_NET_SOCKETS_POSIX_NAMEShas been deprecated in Zephyrin favor of
CONFIG_POSIX_API.CONFIG_POSIX_APIenables additional functionalities other thansockets, resulting in increased footprint.
This commit reuses
ZephyrSocket.hto include Zephyr socketheader and allow building with both configs disabled, adding
neccessary wrappers.