Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChipTool] Add Payload Parse Command #3696

Merged
merged 8 commits into from
Dec 3, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/chip-tool/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ executable("chip-tool") {
"commands/common/Logging.cpp",
"commands/common/ModelCommand.cpp",
"commands/common/NetworkCommand.cpp",
"commands/payload/ParseCommand.cpp",
"main.cpp",
]

Expand Down
20 changes: 20 additions & 0 deletions examples/chip-tool/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,23 @@ To get the list of parameters for a specific command, run the built executable
with the target cluster name and the target command name

$ chip-tool onoff on

## Using the Client for Setup Payload

### How to parse a setup code

To parse a setup code, run the built executable with the `payload` cluster name and the `parse` command

$ chip-tool payload parse code

#### QR Code

$ chip-tool payload parse "CH:#####"

#### QR Code with optional Vendor Info

$ chip-tool chip-tool payload parse "CH:#####"

#### Manual Setup Code

$ chip-tool payload parse :#####"
31 changes: 31 additions & 0 deletions examples/chip-tool/commands/payload/Commands.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
* Copyright (c) 2020 Project CHIP Authors
* All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/

#pragma once

#include "ParseCommand.h"

void registerCommandsPayload(Commands & commands)
{
const char * clusterName = "Payload";
commands_list clusterCommands = {
make_unique<ParseCommand>(),
};

commands.Register(clusterName, clusterCommands);
}
101 changes: 101 additions & 0 deletions examples/chip-tool/commands/payload/ParseCommand.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
/*
* Copyright (c) 2020 Project CHIP Authors
* All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/

#include "ParseCommand.h"
#include <setup_payload/QRCodeSetupPayloadParser.h>
#include <setup_payload/ManualSetupPayloadParser.h>
#include <setup_payload/SetupPayload.h>

using namespace ::chip;
using namespace ::chip::DeviceController;

CHIP_ERROR ParseCommand::Run(ChipDeviceController * dc, NodeId remoteId)
{
std::string codeString(mCode);
SetupPayload payload;

CHIP_ERROR err = CHIP_NO_ERROR;
err = Parse(codeString, payload);
SuccessOrExit(err);

err = Print(payload);
SuccessOrExit(err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a new line

exit:
return err;
}

CHIP_ERROR ParseCommand::Print(chip::SetupPayload payload){
std::string serialNumber;
std::vector<OptionalQRCodeInfo> optionalVendorData;
CHIP_ERROR err = CHIP_NO_ERROR;

ChipLogProgress(SetupPayload, "RequiresCustomFlow: %u", payload.requiresCustomFlow);
ChipLogProgress(SetupPayload, "VendorID: %u", payload.vendorID);
ChipLogProgress(SetupPayload, "Version: %u", payload.version);
ChipLogProgress(SetupPayload, "ProductID: %u", payload.productID);
ChipLogProgress(SetupPayload, "Discriminator: %u", payload.discriminator);
ChipLogProgress(SetupPayload, "SetUpPINCode: %u", payload.setUpPINCode);
ChipLogProgress(SetupPayload, "RendezvousInformation: %u", payload.rendezvousInformation);

if (payload.getSerialNumber(serialNumber) == CHIP_NO_ERROR){
ChipLogProgress(SetupPayload, "SerialNumber: %s", serialNumber.c_str());
}

optionalVendorData = payload.getAllOptionalVendorData();
for (const OptionalQRCodeInfo & info : optionalVendorData)
{
if (info.type == optionalQRCodeInfoTypeString)
{
ChipLogProgress(SetupPayload, "OptionalQRCodeInfo: tag=%u,string value=%s",info.tag, info.data.c_str());
}
else if (info.type == optionalQRCodeInfoTypeInt32)
{
ChipLogProgress(SetupPayload, "OptionalQRCodeInfo: tag=%u,int value=%u",info.tag, info.int32);
}
lijujayakumar marked this conversation as resolved.
Show resolved Hide resolved
else
{
err = CHIP_ERROR_INVALID_ARGUMENT;
}
}

SuccessOrExit(err);

exit:
return err;
}

CHIP_ERROR ParseCommand::Parse(std::string codeString, chip::SetupPayload &payload){

CHIP_ERROR err = CHIP_NO_ERROR;
if(IsQRCode(codeString))
{
ChipLogDetail(SetupPayload, "Parsing base41Representation: %s", codeString.c_str());
err = QRCodeSetupPayloadParser(codeString).populatePayload(payload);
}
else
{
ChipLogDetail(SetupPayload, "Parsing decimalRepresentation: %s", codeString.c_str());
err = ManualSetupPayloadParser(codeString).populatePayload(payload);
}

return err;
}

bool ParseCommand::IsQRCode(std::string codeString){
return codeString.rfind(QRCODE_PREFIX)==0;
}
40 changes: 40 additions & 0 deletions examples/chip-tool/commands/payload/ParseCommand.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
* Copyright (c) 2020 Project CHIP Authors
* All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/

#pragma once

#include "../common/Command.h"
#include <setup_payload/SetupPayload.h>

class ParseCommand : public Command
{
public:
ParseCommand() : Command("parse")
{
AddArgument("code", &mCode);
}

CHIP_ERROR Run(ChipDeviceController * dc, NodeId remoteId) override;

private:
char* mCode;
CHIP_ERROR Parse(std::string codeString, chip::SetupPayload &payload);
CHIP_ERROR Print(chip::SetupPayload payload);
bool IsQRCode(std::string codeString);
const std::string QRCODE_PREFIX = "CH:";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Prefer

static constexpr char QRCODE_PREFIX[] = "CH:";

};
6 changes: 4 additions & 2 deletions examples/chip-tool/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "commands/clusters/Commands.h"
#include "commands/echo/Commands.h"
#include "commands/payload/Commands.h"

// NOTE: Remote device ID is in sync with the echo server device id
// At some point, we may want to add an option to connect to a device without
Expand All @@ -33,9 +34,10 @@ constexpr chip::NodeId kRemoteDeviceId = 12344321;
int main(int argc, char * argv[])
{
Commands commands;

registerCommandsEcho(commands);
registerClusters(commands);
registerCommandsPayload(commands);

registerClusters(commands);

return commands.Run(kLocalDeviceId, kRemoteDeviceId, argc, argv);
}