-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to create out-of-tree MEI clusters #36818
base: master
Are you sure you want to change the base?
Ability to create out-of-tree MEI clusters #36818
Conversation
PR #36818: Size comparison from 75ab4c9 to 3158e54 Full report (3 builds for cc32xx, stm32)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mei" just means "identifier", in Matter... This is trying to show an example of a vendor-prefixed cluster, right? Should probably be named accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is named similar to https://github.com/project-chip/connectedhomeip/blob/master/src/app/clusters/sample-mei-server/sample-mei-server.cpp which is currently in the tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, and that one is not named well and should probably be renamed....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzbarsky-apple I am in the process of updating the complete tree for SampleMei. Is there a way to ignore the 'Check controller-clusters.matter backwards compatibility' check so that the CI jobs are not getting cancelled? Since this is a sample cluster, not a standard matter cluster, this is not a problem for backwards compatibility.
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster. This commits: * adds an example for an external MEI cluster * adds an mei-template.json that creates app-common out-of-tree * adds build system modifications so that app-common which includes the external MEI cluster is being used when EXTERNAL_APP_COMMON is given to chip_configure_data_model().
3158e54
to
6923bb8
Compare
manufacturer-specific-app READMEs
…AfReadAttribute lint step
PR #36818: Size comparison from e7082e2 to 7787e44 Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster.
This commits: