List all NetworkCommissioning cluster attributes in zcl.json and zcl-with-test-extensions.json #36516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
changed the title
lpbeliveau-silabs
approved these changes
Nov 15, 2024
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
e2a8dd6 to
1dc921b
Compare
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
1dc921b to
7cedc68
Compare
bzbarsky-apple
approved these changes
Jan 8, 2025
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
7cedc68 to
2539b7a
Compare
andy31415
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
a90e9c9 to
2e2282d
Compare
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
2e2282d to
66af39d
Compare
|
PR #36516: Size comparison from e0792a4 to 66af39d Full report (3 builds for cc32xx, stm32)
|
|
PR #36516: Size comparison from e0792a4 to 516fdf6 Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
516fdf6 to
df6d5f5
Compare
|
PR #36516: Size comparison from 4f956ec to df6d5f5 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
…ementation. List in in the zcl json
…s. a WirelessDriver is needed
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
df6d5f5 to
a47d646
Compare
|
PR #36516: Size comparison from e86768b to 289fa68 Full report (3 builds for cc32xx, stm32)
|
jmartinez-silabs
force-pushed
the
ConnectMaxTimeSeconds_is_external
branch
from
289fa68 to
336b730
Compare
|
PR #36516: Size comparison from e86768b to 336b730 Full report (3 builds for cc32xx, stm32)
|
|
PR #36516: Size comparison from e86768b to 3862a0c Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All attributes of the network commissioning cluster are from external implementations.
List all of them in :
so they aren't exposed in zap as configurable
for review, Commit 1 : update the JSON files
commit 2 is the regen that updates all .zap and .matter
Testing
Manually verified that zap doesn't show the listed attributes of the network commissioning cluster as configurable.
Code-wise, no real behaviour change Attributes are still readable, but their switch case no longer falls through.
reading
ScanMaxTimeSecondsandConnectMaxTimeSecondsread without a wireless driver initialized would now assert but that shouldn't be possible or a valid configuration either.